From: Lee Jones <lee.jones@linaro.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Mark Brown <broonie@kernel.org>, Keerthy <j-keerthy@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement
Date: Tue, 02 Jul 2019 11:31:57 +0000 [thread overview]
Message-ID: <20190702113157.GG4652@dell> (raw)
In-Reply-To: <4a0a50be-1465-0554-f787-dec72bc07a00@canonical.com>
On Tue, 02 Jul 2019, Colin Ian King wrote:
> On 02/07/2019 11:44, Lee Jones wrote:
> > On Fri, 28 Jun 2019, Colin Ian King wrote:
> >
> >> On 28/06/2019 15:36, Mark Brown wrote:
> >>> On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote:
> >>>> From: Colin Ian King <colin.king@canonical.com>
> >>>>
> >>>> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
> >>>> break statement, causing it to fall through to a dev_err message.
> >>>> Fix this by adding in the missing break statement.
> >>>
> >>> This doesn't apply against current code, please check and resend.
> >>>
> >> So it applies cleanly against linux-next, I think the original code
> >> landed in mfd/for-mfd-next - c.f. https://lkml.org/lkml/2019/5/28/550
> >
> > Applied, thanks Colin.
> >
> I'm confused, who is the official maintainer of the regulator patches
> nowadays?
Mark. But the patch you're fixing is currently in the MFD tree.
I sent him an updated pull-request.
Don't worry mate, you're in good hands. ;)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Colin Ian King <colin.king@canonical.com>
Cc: Mark Brown <broonie@kernel.org>, Keerthy <j-keerthy@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement
Date: Tue, 2 Jul 2019 12:31:57 +0100 [thread overview]
Message-ID: <20190702113157.GG4652@dell> (raw)
In-Reply-To: <4a0a50be-1465-0554-f787-dec72bc07a00@canonical.com>
On Tue, 02 Jul 2019, Colin Ian King wrote:
> On 02/07/2019 11:44, Lee Jones wrote:
> > On Fri, 28 Jun 2019, Colin Ian King wrote:
> >
> >> On 28/06/2019 15:36, Mark Brown wrote:
> >>> On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote:
> >>>> From: Colin Ian King <colin.king@canonical.com>
> >>>>
> >>>> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a
> >>>> break statement, causing it to fall through to a dev_err message.
> >>>> Fix this by adding in the missing break statement.
> >>>
> >>> This doesn't apply against current code, please check and resend.
> >>>
> >> So it applies cleanly against linux-next, I think the original code
> >> landed in mfd/for-mfd-next - c.f. https://lkml.org/lkml/2019/5/28/550
> >
> > Applied, thanks Colin.
> >
> I'm confused, who is the official maintainer of the regulator patches
> nowadays?
Mark. But the patch you're fixing is currently in the MFD tree.
I sent him an updated pull-request.
Don't worry mate, you're in good hands. ;)
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2019-07-02 11:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 13:16 [PATCH][next] regulator: lp87565: fix missing break in switch statement Colin King
2019-06-27 13:16 ` Colin King
2019-06-28 3:28 ` Keerthy
2019-06-28 3:40 ` Keerthy
2019-06-28 14:36 ` Mark Brown
2019-06-28 14:36 ` Mark Brown
2019-06-28 21:18 ` Colin Ian King
2019-06-28 21:18 ` Colin Ian King
2019-07-02 10:44 ` Lee Jones
2019-07-02 10:44 ` Lee Jones
2019-07-02 11:12 ` Colin Ian King
2019-07-02 11:12 ` Colin Ian King
2019-07-02 11:31 ` Lee Jones [this message]
2019-07-02 11:31 ` Lee Jones
2019-07-02 11:36 ` Keerthy
2019-07-02 11:48 ` Keerthy
2019-07-02 12:24 ` Mark Brown
2019-07-02 12:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702113157.GG4652@dell \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=j-keerthy@ti.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.