From: Bjorn Helgaas <helgaas@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pci/proc: Use seq_puts() in show_device()
Date: Tue, 02 Jul 2019 23:46:16 +0000 [thread overview]
Message-ID: <20190702234616.GH128603@google.com> (raw)
In-Reply-To: <a6b110cb-0d0e-5dc3-9ca1-9041609cf74c@web.de>
On Tue, Jul 02, 2019 at 01:26:27PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 Jul 2019 13:21:33 +0200
>
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function “seq_puts”.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied to pci/misc for v5.3, thanks!
> ---
> drivers/pci/proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index 445b51db75b0..fe7fe678965b 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -377,7 +377,7 @@ static int show_device(struct seq_file *m, void *v)
> }
> seq_putc(m, '\t');
> if (drv)
> - seq_printf(m, "%s", drv->name);
> + seq_puts(m, drv->name);
> seq_putc(m, '\n');
> return 0;
> }
> --
> 2.22.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] pci/proc: Use seq_puts() in show_device()
Date: Tue, 2 Jul 2019 18:46:16 -0500 [thread overview]
Message-ID: <20190702234616.GH128603@google.com> (raw)
In-Reply-To: <a6b110cb-0d0e-5dc3-9ca1-9041609cf74c@web.de>
On Tue, Jul 02, 2019 at 01:26:27PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 2 Jul 2019 13:21:33 +0200
>
> A string which did not contain a data format specification should be put
> into a sequence. Thus use the corresponding function “seq_puts”.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied to pci/misc for v5.3, thanks!
> ---
> drivers/pci/proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/proc.c b/drivers/pci/proc.c
> index 445b51db75b0..fe7fe678965b 100644
> --- a/drivers/pci/proc.c
> +++ b/drivers/pci/proc.c
> @@ -377,7 +377,7 @@ static int show_device(struct seq_file *m, void *v)
> }
> seq_putc(m, '\t');
> if (drv)
> - seq_printf(m, "%s", drv->name);
> + seq_puts(m, drv->name);
> seq_putc(m, '\n');
> return 0;
> }
> --
> 2.22.0
>
next prev parent reply other threads:[~2019-07-02 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 11:26 [PATCH] pci/proc: Use seq_puts() in show_device() Markus Elfring
2019-07-02 11:26 ` Markus Elfring
2019-07-02 23:46 ` Bjorn Helgaas [this message]
2019-07-02 23:46 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702234616.GH128603@google.com \
--to=helgaas@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.