From: Nicolin Chen <nicoleotsuka@gmail.com>
To: shengjiu.wang@nxp.com
Cc: timur@kernel.org, Xiubo.Lee@gmail.com, festevam@gmail.com,
broonie@kernel.org, alsa-devel@alsa-project.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] ASoC: fsl_esai: Wrap some operations to be functions
Date: Wed, 3 Jul 2019 02:10:46 -0700 [thread overview]
Message-ID: <20190703091046.GA8764@Asurada> (raw)
In-Reply-To: <f57c5a045c6e5491b1bc9831388eab2c88773176.1562136119.git.shengjiu.wang@nxp.com>
Looks good to me, yet two small comments inline.
Please add this to this patch in the next version:
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
On Wed, Jul 03, 2019 at 02:42:04PM +0800, shengjiu.wang@nxp.com wrote:
> +static int fsl_esai_register_restore(struct fsl_esai *esai_priv)
> +{
> + int ret;
> + /* FIFO reset for safety */
> + regmap_update_bits(esai_priv->regmap, REG_ESAI_TFCR,
Checkpatch script would probably warn this. Usually we add a blank
line after variable declarations.
> @@ -866,22 +935,9 @@ static int fsl_esai_probe(struct platform_device *pdev)
>
> dev_set_drvdata(&pdev->dev, esai_priv);
>
> - /* Reset ESAI unit */
> - ret = regmap_write(esai_priv->regmap, REG_ESAI_ECR, ESAI_ECR_ERST);
> - if (ret) {
> - dev_err(&pdev->dev, "failed to reset ESAI: %d\n", ret);
> + ret = fsl_esai_init(esai_priv);
Could we rename this function to fsl_easi_hw_init() or something
clear like fsl_esai_register_init? fsl_easi_init() feels like a
driver init() function to me.
Thank you
Nicolin
WARNING: multiple messages have this Message-ID (diff)
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: shengjiu.wang@nxp.com
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, festevam@gmail.com,
linux-kernel@vger.kernel.org, broonie@kernel.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 1/2] ASoC: fsl_esai: Wrap some operations to be functions
Date: Wed, 3 Jul 2019 02:10:46 -0700 [thread overview]
Message-ID: <20190703091046.GA8764@Asurada> (raw)
In-Reply-To: <f57c5a045c6e5491b1bc9831388eab2c88773176.1562136119.git.shengjiu.wang@nxp.com>
Looks good to me, yet two small comments inline.
Please add this to this patch in the next version:
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
On Wed, Jul 03, 2019 at 02:42:04PM +0800, shengjiu.wang@nxp.com wrote:
> +static int fsl_esai_register_restore(struct fsl_esai *esai_priv)
> +{
> + int ret;
> + /* FIFO reset for safety */
> + regmap_update_bits(esai_priv->regmap, REG_ESAI_TFCR,
Checkpatch script would probably warn this. Usually we add a blank
line after variable declarations.
> @@ -866,22 +935,9 @@ static int fsl_esai_probe(struct platform_device *pdev)
>
> dev_set_drvdata(&pdev->dev, esai_priv);
>
> - /* Reset ESAI unit */
> - ret = regmap_write(esai_priv->regmap, REG_ESAI_ECR, ESAI_ECR_ERST);
> - if (ret) {
> - dev_err(&pdev->dev, "failed to reset ESAI: %d\n", ret);
> + ret = fsl_esai_init(esai_priv);
Could we rename this function to fsl_easi_hw_init() or something
clear like fsl_esai_register_init? fsl_easi_init() feels like a
driver init() function to me.
Thank you
Nicolin
next prev parent reply other threads:[~2019-07-03 9:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 6:42 [PATCH V2 0/2] recover the channel swap after xrun shengjiu.wang
2019-07-03 6:42 ` [PATCH V2 1/2] ASoC: fsl_esai: Wrap some operations to be functions shengjiu.wang
2019-07-03 9:10 ` Nicolin Chen [this message]
2019-07-03 9:10 ` Nicolin Chen
2019-07-03 6:42 ` [PATCH V2 2/2] ASoC: fsl_esai: recover the channel swap after xrun shengjiu.wang
2019-07-03 9:32 ` Nicolin Chen
2019-07-03 9:32 ` Nicolin Chen
2019-07-03 20:56 ` Cezary Rojewski
2019-07-03 20:56 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703091046.GA8764@Asurada \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=shengjiu.wang@nxp.com \
--cc=timur@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.