From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Kuehling, Felix" <Felix.Kuehling@amd.com>
Cc: "linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"Yang, Philip" <Philip.Yang@amd.com>,
Jason Gunthorpe <jgg@mellanox.com>,
Dave Airlie <airlied@linux.ie>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>
Subject: Re: [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change
Date: Wed, 3 Jul 2019 14:54:43 +1000 [thread overview]
Message-ID: <20190703145443.2ea425c8@canb.auug.org.au> (raw)
In-Reply-To: <20190703015442.11974-1-Felix.Kuehling@amd.com>
[-- Attachment #1: Type: text/plain, Size: 1378 bytes --]
Hi all,
On Wed, 3 Jul 2019 01:55:08 +0000 "Kuehling, Felix" <Felix.Kuehling@amd.com> wrote:
>
> From: Philip Yang <Philip.Yang@amd.com>
>
> In order to pass mirror instead of mm to hmm_range_register, we need
> pass bo instead of ttm to amdgpu_ttm_tt_get_user_pages because mirror
> is part of amdgpu_mn structure, which is accessible from bo.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> CC: Stephen Rothwell <sfr@canb.auug.org.au>
> CC: Jason Gunthorpe <jgg@mellanox.com>
> CC: Dave Airlie <airlied@linux.ie>
> CC: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/Kconfig | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 +--
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 8 ++++++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 5 +++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 12 ++++++++++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 5 +++--
> 8 files changed, 30 insertions(+), 11 deletions(-)
I will apply this to the hmm tree merge today to see how it goes.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: "Kuehling, Felix" <Felix.Kuehling@amd.com>
Cc: "Yang, Philip" <Philip.Yang@amd.com>,
Dave Airlie <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-next@vger.kernel.org" <linux-next@vger.kernel.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
Jason Gunthorpe <jgg@mellanox.com>
Subject: Re: [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change
Date: Wed, 3 Jul 2019 14:54:43 +1000 [thread overview]
Message-ID: <20190703145443.2ea425c8@canb.auug.org.au> (raw)
In-Reply-To: <20190703015442.11974-1-Felix.Kuehling@amd.com>
[-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --]
Hi all,
On Wed, 3 Jul 2019 01:55:08 +0000 "Kuehling, Felix" <Felix.Kuehling@amd.com> wrote:
>
> From: Philip Yang <Philip.Yang@amd.com>
>
> In order to pass mirror instead of mm to hmm_range_register, we need
> pass bo instead of ttm to amdgpu_ttm_tt_get_user_pages because mirror
> is part of amdgpu_mn structure, which is accessible from bo.
>
> Signed-off-by: Philip Yang <Philip.Yang@amd.com>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
> Signed-off-by: Felix Kuehling <Felix.Kuehling@amd.com>
> CC: Stephen Rothwell <sfr@canb.auug.org.au>
> CC: Jason Gunthorpe <jgg@mellanox.com>
> CC: Dave Airlie <airlied@linux.ie>
> CC: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/Kconfig | 1 -
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 5 ++---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 3 +--
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 8 ++++++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_mn.h | 5 +++++
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 12 ++++++++++--
> drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.h | 5 +++--
> 8 files changed, 30 insertions(+), 11 deletions(-)
I will apply this to the hmm tree merge today to see how it goes.
--
Cheers,
Stephen Rothwell
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-03 4:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 1:55 [PATCH 1/1] drm/amdgpu: adopt to hmm_range_register API change Kuehling, Felix
2019-07-03 1:55 ` Kuehling, Felix
2019-07-03 4:54 ` Stephen Rothwell [this message]
2019-07-03 4:54 ` Stephen Rothwell
2019-07-03 8:30 ` Stephen Rothwell
2019-07-03 8:30 ` Stephen Rothwell
2019-07-03 14:10 ` Jason Gunthorpe
2019-07-03 14:10 ` Jason Gunthorpe
2019-07-03 21:03 ` Kuehling, Felix
2019-07-03 21:03 ` Kuehling, Felix
2019-07-03 21:09 ` Alex Deucher
2019-07-03 21:09 ` Alex Deucher
2019-07-03 21:32 ` Stephen Rothwell
2019-07-03 21:32 ` Stephen Rothwell
2019-07-03 23:11 ` Dave Airlie
2019-07-03 23:11 ` Dave Airlie
2019-07-04 2:00 ` Jason Gunthorpe
2019-07-04 2:00 ` Jason Gunthorpe
2019-07-04 2:01 ` Jason Gunthorpe
2019-07-04 2:01 ` Jason Gunthorpe
2019-07-07 23:30 ` Stephen Rothwell
2019-07-07 23:30 ` Stephen Rothwell
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 14:09 ` Jason Gunthorpe
2019-07-08 15:26 ` Kuehling, Felix
2019-07-08 15:26 ` Kuehling, Felix
2019-07-08 15:35 ` Stephen Rothwell
2019-07-08 15:35 ` Stephen Rothwell
2019-07-03 21:33 ` Stephen Rothwell
2019-07-03 21:33 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703145443.2ea425c8@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Alexander.Deucher@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=Philip.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgg@mellanox.com \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.