From: Matthias Kaehlcke <mka@chromium.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Rob Herring <robh+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs
Date: Wed, 3 Jul 2019 15:08:43 -0700 [thread overview]
Message-ID: <20190703220843.GJ250418@google.com> (raw)
In-Reply-To: <20190703213327.GH18473@lunn.ch>
On Wed, Jul 03, 2019 at 11:33:27PM +0200, Andrew Lunn wrote:
> > I think if we're going to have custom properties for phys, we should
> > have a compatible string to at least validate whether the custom
> > properties are even valid for the node.
>
> Hi Rob
>
> What happens with other enumerable busses where a compatible string is
> not used?
>
> The Ethernet PHY subsystem will ignore the compatible string and load
> the driver which fits the enumeration data. Using the compatible
> string only to get the right YAML validator seems wrong. I would
> prefer adding some other property with a clear name indicates its is
> selecting the validator, and has nothing to do with loading the
> correct driver. And it can then be used as well for USB and PCI
> devices etc.
I also have doubts whether a compatible string is the right answer
here. It's not needed/used by the subsystem, but would it be a
required property because it's needed for validation?
next prev parent reply other threads:[~2019-07-03 22:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 19:37 [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs Matthias Kaehlcke
2019-07-03 19:37 ` [PATCH v2 2/7] net: phy: realtek: Allow disabling RTL8211E EEE LED mode Matthias Kaehlcke
2019-07-03 20:09 ` Heiner Kallweit
2019-07-03 20:32 ` Matthias Kaehlcke
2019-07-03 19:37 ` [PATCH v2 3/7] dt-bindings: net: realtek: Add property to enable SSC Matthias Kaehlcke
2019-07-03 19:37 ` [PATCH v2 4/7] net: phy: realtek: Enable accessing RTL8211E extension pages Matthias Kaehlcke
2019-07-03 20:12 ` Heiner Kallweit
2019-07-03 20:36 ` Matthias Kaehlcke
2019-07-03 21:01 ` Heiner Kallweit
2019-07-03 21:24 ` Matthias Kaehlcke
2019-07-03 21:27 ` Heiner Kallweit
2019-07-03 22:56 ` Matthias Kaehlcke
2019-07-03 19:37 ` [PATCH v2 5/7] net: phy: realtek: Support SSC for the RTL8211E Matthias Kaehlcke
2019-07-03 19:37 ` [PATCH v2 6/7] dt-bindings: net: realtek: Add property to configure LED mode Matthias Kaehlcke
2019-07-03 20:07 ` Andrew Lunn
2019-07-03 20:13 ` Heiner Kallweit
2019-07-03 20:22 ` Heiner Kallweit
2019-07-03 21:37 ` Florian Fainelli
2019-07-03 23:23 ` Matthias Kaehlcke
2019-07-10 15:55 ` Rob Herring
2019-07-10 16:28 ` Florian Fainelli
2019-07-12 17:28 ` Matthias Kaehlcke
2019-07-12 17:20 ` Matthias Kaehlcke
2019-07-22 17:14 ` Matthias Kaehlcke
2019-07-22 19:01 ` Andrew Lunn
2019-07-22 19:14 ` Matthias Kaehlcke
2019-07-22 19:38 ` Andrew Lunn
2019-07-03 19:37 ` [PATCH v2 7/7] net: phy: realtek: configure RTL8211E LEDs Matthias Kaehlcke
2019-07-03 20:10 ` Andrew Lunn
2019-07-03 20:43 ` Matthias Kaehlcke
2019-07-03 20:28 ` Heiner Kallweit
2019-07-03 20:45 ` Matthias Kaehlcke
2019-07-03 20:21 ` [PATCH v2 1/7] dt-bindings: net: Add bindings for Realtek PHYs David Miller
2019-07-03 21:11 ` Rob Herring
2019-07-03 21:33 ` Andrew Lunn
2019-07-03 22:08 ` Matthias Kaehlcke [this message]
2019-07-05 16:18 ` Rob Herring
2019-07-05 16:17 ` Rob Herring
2019-07-05 16:29 ` Andrew Lunn
2019-07-05 17:07 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703220843.GJ250418@google.com \
--to=mka@chromium.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.