All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data()
@ 2019-07-02  2:56 ` Yue Hu
  0 siblings, 0 replies; 12+ messages in thread
From: Yue Hu @ 2019-07-02  2:56 UTC (permalink / raw)


From: Yue Hu <huyue2@yulong.com>

Already check if ->datamode is supported in read_inode(), no need to check
again in the next fill_inline_data() only called by fill_inode().

Signed-off-by: Yue Hu <huyue2 at yulong.com>
Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
Reviewed-by: Chao Yu <yuchao0 at huawei.com>
---
no change

 drivers/staging/erofs/inode.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
index e51348f..d6e1e16 100644
--- a/drivers/staging/erofs/inode.c
+++ b/drivers/staging/erofs/inode.c
@@ -129,8 +129,6 @@ static int fill_inline_data(struct inode *inode, void *data,
 	struct erofs_sb_info *sbi = EROFS_I_SB(inode);
 	const int mode = vi->datamode;
 
-	DBG_BUGON(mode >= EROFS_INODE_LAYOUT_MAX);
-
 	/* should be inode inline C */
 	if (mode != EROFS_INODE_LAYOUT_INLINE)
 		return 0;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2019-07-04 10:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-02  2:56 [PATCH RESEND v3] staging: erofs: remove unsupported ->datamode check in fill_inline_data() Yue Hu
2019-07-02  2:56 ` Yue Hu
2019-07-03 16:20 ` Greg KH
2019-07-03 16:20   ` Greg KH
2019-07-04  1:59   ` Yue Hu
2019-07-04  1:59     ` Yue Hu
2019-07-04  5:26     ` Greg KH
2019-07-04  5:26       ` Greg KH
2019-07-04 10:02       ` Yue Hu
2019-07-04 10:02         ` Yue Hu
2019-07-04 10:31         ` Gao Xiang
2019-07-04 10:31           ` Gao Xiang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.