From: Joerg Roedel <joro@8bytes.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap-iommu: no need to check return value of debugfs_create functions
Date: Thu, 4 Jul 2019 17:35:52 +0200 [thread overview]
Message-ID: <20190704153551.GG3310@8bytes.org> (raw)
In-Reply-To: <20190704143649.GA11697@kroah.com>
On Thu, Jul 04, 2019 at 04:36:49PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Warning, not even test-built, but "should" work :)
It almost did :)
> + debugfs_create_file("regs", 0400, d, obj, &attrregs_fops);
> + debugfs_create_file("tlb", 0400, d, obj, &attrtlb_fops);
> + debugfs_create_file("pagetable", 0400, d, obj, &attrpagetable_fops);
The _fops were named without the 'attr' prefix, changed that and it
compiled. Patch is now applied.
Thanks,
Joerg
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] omap-iommu: no need to check return value of debugfs_create functions
Date: Thu, 4 Jul 2019 17:35:52 +0200 [thread overview]
Message-ID: <20190704153551.GG3310@8bytes.org> (raw)
In-Reply-To: <20190704143649.GA11697@kroah.com>
On Thu, Jul 04, 2019 at 04:36:49PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: iommu@lists.linux-foundation.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> Warning, not even test-built, but "should" work :)
It almost did :)
> + debugfs_create_file("regs", 0400, d, obj, &attrregs_fops);
> + debugfs_create_file("tlb", 0400, d, obj, &attrtlb_fops);
> + debugfs_create_file("pagetable", 0400, d, obj, &attrpagetable_fops);
The _fops were named without the 'attr' prefix, changed that and it
compiled. Patch is now applied.
Thanks,
Joerg
next prev parent reply other threads:[~2019-07-04 15:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 14:36 [PATCH] omap-iommu: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-07-04 14:36 ` Greg Kroah-Hartman
2019-07-04 15:35 ` Joerg Roedel [this message]
2019-07-04 15:35 ` Joerg Roedel
2019-07-05 5:24 ` Greg Kroah-Hartman
2019-07-05 5:24 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190704153551.GG3310@8bytes.org \
--to=joro@8bytes.org \
--cc=gregkh@linuxfoundation.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.