From: Luis Chamberlain <mcgrof@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org,
jpoimboe@redhat.com, keescook@google.com,
kieran.bingham@ideasonboard.com, peterz@infradead.org,
robh@kernel.org, sboyd@kernel.org, shuah@kernel.org,
tytso@mit.edu, yamada.masahiro@socionext.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch,
jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr,
khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com,
mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org,
richard@nod.at, rientjes@google.com, rostedt@goodmis.org,
wfg@linux.intel.com
Subject: Re: [PATCH v6 02/18] kunit: test: add test resource management API
Date: Fri, 5 Jul 2019 20:45:37 +0000 [thread overview]
Message-ID: <20190705204537.GC19023@42.do-not-panic.com> (raw)
In-Reply-To: <20190704003615.204860-3-brendanhiggins@google.com>
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote:
> diff --git a/kunit/test.c b/kunit/test.c
> index c030ba5a43e40..a70fbe449e922 100644
> --- a/kunit/test.c
> +++ b/kunit/test.c
> @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct kunit_case *test_case,
>
> void kunit_init_test(struct kunit *test, const char *name)
> {
> - spin_lock_init(&test->lock);
Once you re-spin, this above line should be removed.
> + mutex_init(&test->lock);
> + INIT_LIST_HEAD(&test->resources);
> test->name = name;
> test->success = true;
> }
Luis
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: pmladek@suse.com, linux-doc@vger.kernel.org,
peterz@infradead.org, amir73il@gmail.com,
dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
yamada.masahiro@socionext.com, mpe@ellerman.id.au,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
robh@kernel.org, linux-nvdimm@lists.01.org,
frowand.list@gmail.com, knut.omang@oracle.com,
kieran.bingham@ideasonboard.com, wfg@linux.intel.com,
joel@jms.id.au, rientjes@google.com, jdike@addtoit.com,
dan.carpenter@oracle.com, devicetree@vger.kernel.org,
linux-kbuild@vger.kernel.org, Tim.Bird@sony.com,
linux-um@lists.infradead.org, rostedt@goodmis.org,
julia.lawall@lip6.fr, jpoimboe@redhat.com,
kunit-dev@googlegroups.com, tytso@mit.edu, richard@nod.at,
sboyd@kernel.org, gregkh@linuxfoundation.org,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, keescook@google.com,
linux-fsdevel@vger.kernel.org, khilman@baylibre.com
Subject: Re: [PATCH v6 02/18] kunit: test: add test resource management API
Date: Fri, 5 Jul 2019 20:45:37 +0000 [thread overview]
Message-ID: <20190705204537.GC19023@42.do-not-panic.com> (raw)
In-Reply-To: <20190704003615.204860-3-brendanhiggins@google.com>
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote:
> diff --git a/kunit/test.c b/kunit/test.c
> index c030ba5a43e40..a70fbe449e922 100644
> --- a/kunit/test.c
> +++ b/kunit/test.c
> @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct kunit_case *test_case,
>
> void kunit_init_test(struct kunit *test, const char *name)
> {
> - spin_lock_init(&test->lock);
Once you re-spin, this above line should be removed.
> + mutex_init(&test->lock);
> + INIT_LIST_HEAD(&test->resources);
> test->name = name;
> test->success = true;
> }
Luis
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: pmladek@suse.com, linux-doc@vger.kernel.org,
peterz@infradead.org, amir73il@gmail.com,
dri-devel@lists.freedesktop.org, Alexander.Levin@microsoft.com,
yamada.masahiro@socionext.com, mpe@ellerman.id.au,
linux-kselftest@vger.kernel.org, shuah@kernel.org,
robh@kernel.org, linux-nvdimm@lists.01.org,
frowand.list@gmail.com, knut.omang@oracle.com,
kieran.bingham@ideasonboard.com, wfg@linux.intel.com,
joel@jms.id.au, rientjes@google.com, jdike@addtoit.com,
dan.carpenter@oracle.com, devicetree@vger.kernel.org,
linux-kbuild@vger.kernel.org, Tim.Bird@sony.com,
linux-um@lists.infradead.org, rostedt@goodmis.org,
julia.lawall@lip6.fr, jpoimboe@redhat.com,
kunit-dev@googlegroups.com, tytso@mit.edu, richard@nod.at,
sboyd@kernel.org, gregkh@linuxfoundation.org,
rdunlap@infradead.org, linux-kernel@vger.kernel.org,
daniel@ffwll.ch, keescook@google.com,
linux-fsdevel@vger.kernel.org, logang@deltatee.com,
khilman@baylibre.com
Subject: Re: [PATCH v6 02/18] kunit: test: add test resource management API
Date: Fri, 5 Jul 2019 20:45:37 +0000 [thread overview]
Message-ID: <20190705204537.GC19023@42.do-not-panic.com> (raw)
In-Reply-To: <20190704003615.204860-3-brendanhiggins@google.com>
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote:
> diff --git a/kunit/test.c b/kunit/test.c
> index c030ba5a43e40..a70fbe449e922 100644
> --- a/kunit/test.c
> +++ b/kunit/test.c
> @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct kunit_case *test_case,
>
> void kunit_init_test(struct kunit *test, const char *name)
> {
> - spin_lock_init(&test->lock);
Once you re-spin, this above line should be removed.
> + mutex_init(&test->lock);
> + INIT_LIST_HEAD(&test->resources);
> test->name = name;
> test->success = true;
> }
Luis
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
WARNING: multiple messages have this Message-ID (diff)
From: Luis Chamberlain <mcgrof@kernel.org>
To: Brendan Higgins <brendanhiggins@google.com>
Cc: frowand.list@gmail.com, gregkh@linuxfoundation.org,
jpoimboe@redhat.com, keescook@google.com,
kieran.bingham@ideasonboard.com, peterz@infradead.org,
robh@kernel.org, sboyd@kernel.org, shuah@kernel.org,
tytso@mit.edu, yamada.masahiro@socionext.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
kunit-dev@googlegroups.com, linux-doc@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-nvdimm@lists.01.org, linux-um@lists.infradead.org,
Alexander.Levin@microsoft.com, Tim.Bird@sony.com,
amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch,
jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr,
khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com,
mpe@ellerma
Subject: Re: [PATCH v6 02/18] kunit: test: add test resource management API
Date: Fri, 5 Jul 2019 20:45:37 +0000 [thread overview]
Message-ID: <20190705204537.GC19023@42.do-not-panic.com> (raw)
In-Reply-To: <20190704003615.204860-3-brendanhiggins@google.com>
On Wed, Jul 03, 2019 at 05:35:59PM -0700, Brendan Higgins wrote:
> diff --git a/kunit/test.c b/kunit/test.c
> index c030ba5a43e40..a70fbe449e922 100644
> --- a/kunit/test.c
> +++ b/kunit/test.c
> @@ -122,7 +122,8 @@ static void kunit_print_test_case_ok_not_ok(struct kunit_case *test_case,
>
> void kunit_init_test(struct kunit *test, const char *name)
> {
> - spin_lock_init(&test->lock);
Once you re-spin, this above line should be removed.
> + mutex_init(&test->lock);
> + INIT_LIST_HEAD(&test->resources);
> test->name = name;
> test->success = true;
> }
Luis
next prev parent reply other threads:[~2019-07-05 20:45 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 0:35 [PATCH v6 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Brendan Higgins
2019-07-04 0:35 ` Brendan Higgins
2019-07-04 0:35 ` [PATCH v6 01/18] kunit: test: add KUnit test runner core Brendan Higgins
2019-07-04 0:35 ` Brendan Higgins
2019-07-04 0:35 ` Brendan Higgins
2019-07-05 20:15 ` Luis Chamberlain
2019-07-05 20:15 ` Luis Chamberlain
2019-07-05 20:15 ` Luis Chamberlain
2019-07-05 20:15 ` Luis Chamberlain
2019-07-08 18:08 ` Brendan Higgins
2019-07-08 18:08 ` Brendan Higgins
2019-07-08 18:08 ` Brendan Higgins
2019-07-08 20:40 ` Brendan Higgins
2019-07-08 20:40 ` Brendan Higgins
2019-07-08 20:40 ` Brendan Higgins
2019-07-05 20:20 ` Luis Chamberlain
2019-07-05 20:20 ` Luis Chamberlain
2019-07-05 20:20 ` Luis Chamberlain
2019-07-05 20:20 ` Luis Chamberlain
2019-07-08 18:12 ` Brendan Higgins
2019-07-08 18:12 ` Brendan Higgins
2019-07-08 18:12 ` Brendan Higgins
2019-07-04 0:35 ` [PATCH v6 02/18] kunit: test: add test resource management API Brendan Higgins
2019-07-04 0:35 ` Brendan Higgins
2019-07-04 0:35 ` Brendan Higgins
2019-07-05 20:45 ` Luis Chamberlain [this message]
2019-07-05 20:45 ` Luis Chamberlain
2019-07-05 20:45 ` Luis Chamberlain
2019-07-05 20:45 ` Luis Chamberlain
2019-07-04 0:36 ` [PATCH v6 03/18] kunit: test: add string_stream a std::stream like string builder Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 04/18] kunit: test: add kunit_stream a std::stream like logger Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 05/18] kunit: test: add the concept of expectations Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 06/18] kbuild: enable building KUnit Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 07/18] kunit: test: add initial tests Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 08/18] objtool: add kunit_try_catch_throw to the noreturn list Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 09/18] kunit: test: add support for test abort Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 10/18] kunit: test: add tests for kunit " Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 11/18] kunit: test: add the concept of assertions Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 12/18] kunit: test: add tests for KUnit managed resources Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 13/18] kunit: tool: add Python wrappers for running KUnit tests Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 14/18] kunit: defconfig: add defconfigs for building " Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 15/18] Documentation: kunit: add documentation for KUnit Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 16/18] MAINTAINERS: add entry for KUnit the unit testing framework Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` [PATCH v6 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec() Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-05 20:45 ` Luis Chamberlain
2019-07-05 20:45 ` Luis Chamberlain
2019-07-05 20:45 ` Luis Chamberlain
2019-07-04 0:36 ` [PATCH v6 18/18] MAINTAINERS: add proc sysctl KUnit test to PROC SYSCTL section Brendan Higgins
2019-07-04 0:36 ` Brendan Higgins
2019-07-05 20:48 ` Luis Chamberlain
2019-07-05 20:48 ` Luis Chamberlain
2019-07-05 20:48 ` Luis Chamberlain
2019-07-05 20:48 ` Luis Chamberlain
2019-07-08 23:15 ` Brendan Higgins
2019-07-08 23:15 ` Brendan Higgins
2019-07-08 23:15 ` Brendan Higgins
[not found] ` <CAFd5g44j7ECQorYLnDQadAaj+yBki98kFjmjejn+3W4eHtqGDA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-07-08 23:29 ` Iurii Zaikin
2019-07-08 23:34 ` Iurii Zaikin
2019-07-08 23:34 ` Iurii Zaikin
2019-07-08 23:34 ` Iurii Zaikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705204537.GC19023@42.do-not-panic.com \
--to=mcgrof@kernel.org \
--cc=Alexander.Levin@microsoft.com \
--cc=Tim.Bird@sony.com \
--cc=amir73il@gmail.com \
--cc=brendanhiggins@google.com \
--cc=dan.carpenter@oracle.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdike@addtoit.com \
--cc=joel@jms.id.au \
--cc=jpoimboe@redhat.com \
--cc=julia.lawall@lip6.fr \
--cc=keescook@google.com \
--cc=khilman@baylibre.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-um@lists.infradead.org \
--cc=logang@deltatee.com \
--cc=mpe@ellerman.id.au \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=richard@nod.at \
--cc=rientjes@google.com \
--cc=robh@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sboyd@kernel.org \
--cc=shuah@kernel.org \
--cc=tytso@mit.edu \
--cc=wfg@linux.intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.