[RFC] nvme-tcp: Use protocol specific operations while reading socket

[RFC] nvme-tcp: Use protocol specific operations while reading socket

[Potnuri Bharat Teja]

Using socket specific read_sock() calls instead of directly calling
tcp_read_sock() helps lld module registered handlers if any, to be called
from nvme-tcp host.
This patch therefore replaces the tcp_read_sock() with socket specific
prot_ops.

Signed-off-by: Potnuri Bharat Teja <bharat at chelsio.com>
---
 drivers/nvme/host/tcp.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 08a2501b9357..6ba667e62b75 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -1016,14 +1016,15 @@ static int nvme_tcp_try_send(struct nvme_tcp_queue *queue)
 
 static int nvme_tcp_try_recv(struct nvme_tcp_queue *queue)
 {
-	struct sock *sk = queue->sock->sk;
+	struct socket *sock = queue->sock;
+	struct sock *sk = sock->sk;
 	read_descriptor_t rd_desc;
 	int consumed;
 
 	rd_desc.arg.data = queue;
 	rd_desc.count = 1;
 	lock_sock(sk);
-	consumed = tcp_read_sock(sk, &rd_desc, nvme_tcp_recv_skb);
+	consumed = sock->ops->read_sock(sk, &rd_desc, nvme_tcp_recv_skb);
 	release_sock(sk);
 	return consumed;
 }
-- 
2.18.0.232.gb7bd9486b055

[RFC] nvme-tcp: Use protocol specific operations while reading socket

[Sagi Grimberg]

Potnuri, this seems fine to me,

Acked-by: Sagi Grimberg <sagi at grimberg.me>

[RFC] nvme-tcp: Use protocol specific operations while reading socket

[potnuri bharat teja]

On Monday, July 07/08/19, 2019@02:36:28 -0700, Sagi Grimberg wrote:
> Potnuri, this seems fine to me,
> 
> Acked-by: Sagi Grimberg <sagi at grimberg.me>

Thanks Sagi.
Shall send it out as Patch.