From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Markus Elfring <Markus.Elfring@web.de>,
kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/topology: One function call less in build_group_from_child_sched_domain()
Date: Mon, 08 Jul 2019 14:39:36 +0000 [thread overview]
Message-ID: <20190708142736.GC10675@linux.vnet.ibm.com> (raw)
In-Reply-To: <65dedcbc-aefb-eb30-39e1-194248214369@metux.net>
* Enrico Weigelt, metux IT consult <lkml@metux.net> [2019-07-08 11:38:58]:
> >
> > At runtime, Are we avoiding a function call?
> > However I think we are avoiding a branch instead of a conditional, which may
> > be beneficial.
>
> If you're assuming the compiler doesn't already optimize that (no idea
> whether gcc really does that).
>
> @Markus: could you check what gcc is actually generating out of both the
> old and your new version ?
>
>
I had already tried looking at the object files both on X86 and PowerPc and
in both cases (with and without patch) the generated code differs.
> --mtx
>
> --
> Enrico Weigelt, metux IT consult
> Free software and Linux embedded engineering
> info@metux.net -- +49-151-27565287
>
--
Thanks and Regards
Srikar Dronamraju
WARNING: multiple messages have this Message-ID (diff)
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Markus Elfring <Markus.Elfring@web.de>,
kernel-janitors@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sched/topology: One function call less in build_group_from_child_sched_domain()
Date: Mon, 8 Jul 2019 19:57:36 +0530 [thread overview]
Message-ID: <20190708142736.GC10675@linux.vnet.ibm.com> (raw)
In-Reply-To: <65dedcbc-aefb-eb30-39e1-194248214369@metux.net>
* Enrico Weigelt, metux IT consult <lkml@metux.net> [2019-07-08 11:38:58]:
> >
> > At runtime, Are we avoiding a function call?
> > However I think we are avoiding a branch instead of a conditional, which may
> > be beneficial.
>
> If you're assuming the compiler doesn't already optimize that (no idea
> whether gcc really does that).
>
> @Markus: could you check what gcc is actually generating out of both the
> old and your new version ?
>
>
I had already tried looking at the object files both on X86 and PowerPc and
in both cases (with and without patch) the generated code differs.
> --mtx
>
> --
> Enrico Weigelt, metux IT consult
> Free software and Linux embedded engineering
> info@metux.net -- +49-151-27565287
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2019-07-08 14:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 14:05 [PATCH] sched/topology: One function call less in build_group_from_child_sched_domain() Markus Elfring
2019-07-06 14:05 ` Markus Elfring
2019-07-06 17:22 ` Srikar Dronamraju
2019-07-06 17:34 ` Srikar Dronamraju
2019-07-08 9:38 ` Enrico Weigelt, metux IT consult
2019-07-08 9:38 ` Enrico Weigelt, metux IT consult
2019-07-08 14:27 ` Srikar Dronamraju [this message]
2019-07-08 14:39 ` Srikar Dronamraju
2019-07-08 10:23 ` Peter Zijlstra
2019-07-08 10:23 ` Peter Zijlstra
2019-07-08 14:07 ` Srikar Dronamraju
2019-07-08 14:19 ` Srikar Dronamraju
2019-07-08 15:44 ` Markus Elfring
2019-07-08 15:44 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708142736.GC10675@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@metux.net \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.