All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	linux-kernel@vger.kernel.org,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-mtd@lists.infradead.org,
	clang-built-linux@googlegroups.com,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: remove c++ comments from uapi header
Date: Mon, 8 Jul 2019 14:54:26 +0200	[thread overview]
Message-ID: <20190708145426.62b4aabd@xps13> (raw)
In-Reply-To: <20190708124946.3679242-1-arnd@arndb.de>

Hi Arnd,

Arnd Bergmann <arnd@arndb.de> wrote on Mon,  8 Jul 2019 14:49:39 +0200:

> Checking the uapi headers now produces a warning with clang:
> 
> ./usr/include/mtd/mtd-abi.h:116:28: error: // comments are not allowed in this language [-Werror,-Wcomment]
> 
> Change these into standard C comments here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/uapi/mtd/mtd-abi.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
> index aff5b5e59845..47ffe3208c27 100644
> --- a/include/uapi/mtd/mtd-abi.h
> +++ b/include/uapi/mtd/mtd-abi.h
> @@ -113,11 +113,11 @@ struct mtd_write_req {
>  #define MTD_CAP_NVRAM		(MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
>  
>  /* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
> -#define MTD_NANDECC_OFF		0	// Switch off ECC (Not recommended)
> -#define MTD_NANDECC_PLACE	1	// Use the given placement in the structure (YAFFS1 legacy mode)
> -#define MTD_NANDECC_AUTOPLACE	2	// Use the default placement scheme
> -#define MTD_NANDECC_PLACEONLY	3	// Use the given placement in the structure (Do not store ecc result on read)
> -#define MTD_NANDECC_AUTOPL_USR 	4	// Use the given autoplacement scheme rather than using the default
> +#define MTD_NANDECC_OFF		0	/* Switch off ECC (Not recommended) */
> +#define MTD_NANDECC_PLACE	1	/* Use the given placement in the structure (YAFFS1 legacy mode) */
> +#define MTD_NANDECC_AUTOPLACE	2	/* Use the default placement scheme */
> +#define MTD_NANDECC_PLACEONLY	3	/* Use the given placement in the structure (Do not store ecc result on read) */
> +#define MTD_NANDECC_AUTOPL_USR 	4	/* Use the given autoplacement scheme rather than using the default */
>  
>  /* OTP mode selection */
>  #define MTD_OTP_OFF		0

A similar patch has been sent a few weeks ago and has been applied
yesterday night so it should have appeared this morning in linux-next :)


Thanks anyway!
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
	clang-built-linux@googlegroups.com
Subject: Re: [PATCH] mtd: remove c++ comments from uapi header
Date: Mon, 8 Jul 2019 14:54:26 +0200	[thread overview]
Message-ID: <20190708145426.62b4aabd@xps13> (raw)
In-Reply-To: <20190708124946.3679242-1-arnd@arndb.de>

Hi Arnd,

Arnd Bergmann <arnd@arndb.de> wrote on Mon,  8 Jul 2019 14:49:39 +0200:

> Checking the uapi headers now produces a warning with clang:
> 
> ./usr/include/mtd/mtd-abi.h:116:28: error: // comments are not allowed in this language [-Werror,-Wcomment]
> 
> Change these into standard C comments here.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/uapi/mtd/mtd-abi.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/include/uapi/mtd/mtd-abi.h b/include/uapi/mtd/mtd-abi.h
> index aff5b5e59845..47ffe3208c27 100644
> --- a/include/uapi/mtd/mtd-abi.h
> +++ b/include/uapi/mtd/mtd-abi.h
> @@ -113,11 +113,11 @@ struct mtd_write_req {
>  #define MTD_CAP_NVRAM		(MTD_WRITEABLE | MTD_BIT_WRITEABLE | MTD_NO_ERASE)
>  
>  /* Obsolete ECC byte placement modes (used with obsolete MEMGETOOBSEL) */
> -#define MTD_NANDECC_OFF		0	// Switch off ECC (Not recommended)
> -#define MTD_NANDECC_PLACE	1	// Use the given placement in the structure (YAFFS1 legacy mode)
> -#define MTD_NANDECC_AUTOPLACE	2	// Use the default placement scheme
> -#define MTD_NANDECC_PLACEONLY	3	// Use the given placement in the structure (Do not store ecc result on read)
> -#define MTD_NANDECC_AUTOPL_USR 	4	// Use the given autoplacement scheme rather than using the default
> +#define MTD_NANDECC_OFF		0	/* Switch off ECC (Not recommended) */
> +#define MTD_NANDECC_PLACE	1	/* Use the given placement in the structure (YAFFS1 legacy mode) */
> +#define MTD_NANDECC_AUTOPLACE	2	/* Use the default placement scheme */
> +#define MTD_NANDECC_PLACEONLY	3	/* Use the given placement in the structure (Do not store ecc result on read) */
> +#define MTD_NANDECC_AUTOPL_USR 	4	/* Use the given autoplacement scheme rather than using the default */
>  
>  /* OTP mode selection */
>  #define MTD_OTP_OFF		0

A similar patch has been sent a few weeks ago and has been applied
yesterday night so it should have appeared this morning in linux-next :)


Thanks anyway!
Miquèl

  reply	other threads:[~2019-07-08 12:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 12:49 [PATCH] mtd: remove c++ comments from uapi header Arnd Bergmann
2019-07-08 12:49 ` Arnd Bergmann
2019-07-08 12:54 ` Miquel Raynal [this message]
2019-07-08 12:54   ` Miquel Raynal
2019-07-08 13:22   ` Arnd Bergmann
2019-07-08 13:22     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190708145426.62b4aabd@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=vigneshr@ti.com \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.