From: Christoph Hellwig <hch@infradead.org>
To: Petr Vorel <petr.vorel@gmail.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start
Date: Mon, 8 Jul 2019 19:47:43 -0700 [thread overview]
Message-ID: <20190709024742.GA22293@infradead.org> (raw)
In-Reply-To: <20190708213551.26349-1-petr.vorel@gmail.com>
> -//typedef int daddr_t; /* or long - check */
> -
> struct solaris_x86_slice {
> unsigned short s_tag; /* ID tag of partition */
> unsigned short s_flag; /* permission flags */
> - long s_start; /* start sector no of partition */
> + __kernel_daddr_t s_start; /* start sector no of partition */
> long s_size; /* # of blocks in partition */
> };
What this really should use is fixed size types.
next prev parent reply other threads:[~2019-07-09 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 21:35 [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start Petr Vorel
2019-07-09 2:47 ` Christoph Hellwig [this message]
2019-07-09 8:02 ` Petr Vorel
2019-07-09 13:34 ` Christoph Hellwig
2019-10-02 6:05 ` Petr Vorel
2019-10-07 16:57 ` Christoph Hellwig
2019-10-08 8:18 ` Petr Vorel
2019-10-12 9:01 ` Baruch Even
2019-10-12 19:08 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709024742.GA22293@infradead.org \
--to=hch@infradead.org \
--cc=dm-devel@redhat.com \
--cc=petr.vorel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.