All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Baruch Even <baruch@ev-en.org>
Cc: Christoph Hellwig <hch@infradead.org>, dm-devel@redhat.com
Subject: Re: [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start
Date: Sat, 12 Oct 2019 21:08:36 +0200	[thread overview]
Message-ID: <20191012190835.GA6490@x230> (raw)
In-Reply-To: <CAC9+an+8SgNnR7Sr=Q8MKEN9ykPwL2q4LvSTE3C9OisDrN=pKg@mail.gmail.com>

Hi Baruch,

> Hi,

> The patch looks good to me, as for gpart, I needed it so I've taken the
> bits and pieces that floated around and merged them all into one place from
> all distributions that I could find.   As for users, in Debian the number
> of users is around 250 so it's a very low usage program but I guess that
> would always be unless very many people lost their partitions every day :-)

> https://qa.debian.org/popcon-graph.php?packages=gpart

> Cheers,
> Baruch

> P.S. While I'm sort of maintaining the program, it's only maintenance, no
> active development is going on with it and very rarely do I get a patch or
> an issue reported.

Thanks for info. FYI (even you don't do active development), although this patch
was merged, it's IMHO wrong approach.
I've sent better approach [1] and I'm going to send v2, which uses uint{16,32}_t
instead of uint{16,32}_t (fixed size types are good enough).
I'll Cc you in new patch, but feel free to ignore it.

Kind regards,
Petr

[1] https://www.redhat.com/archives/dm-devel/2019-October/msg00058.html

      reply	other threads:[~2019-10-12 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-08 21:35 [PATCH 1/1] kpartx: Use __kernel_daddr_t for solaris_x86_slice.s_start Petr Vorel
2019-07-09  2:47 ` Christoph Hellwig
2019-07-09  8:02   ` Petr Vorel
2019-07-09 13:34     ` Christoph Hellwig
2019-10-02  6:05       ` Petr Vorel
2019-10-07 16:57         ` Christoph Hellwig
2019-10-08  8:18           ` Petr Vorel
2019-10-12  9:01             ` Baruch Even
2019-10-12 19:08               ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191012190835.GA6490@x230 \
    --to=petr.vorel@gmail.com \
    --cc=baruch@ev-en.org \
    --cc=dm-devel@redhat.com \
    --cc=hch@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.