From: Bharata B Rao <bharata@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, paulus@au1.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com,
linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com,
cclaudio@linux.ibm.com
Subject: Re: [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls
Date: Tue, 09 Jul 2019 10:17:26 +0000 [thread overview]
Message-ID: <20190709100526.GC27933@in.ibm.com> (raw)
In-Reply-To: <87y31y7avd.fsf@morokweng.localdomain>
On Tue, Jun 18, 2019 at 08:05:26PM -0300, Thiago Jung Bauermann wrote:
>
> Hello Bharata,
>
> Bharata B Rao <bharata@linux.ibm.com> writes:
>
> > diff --git a/arch/powerpc/include/asm/kvm_book3s_hmm.h b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > index 21f3de5f2acb..3e13dab7f690 100644
> > --- a/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > +++ b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > @@ -11,6 +11,8 @@ extern unsigned long kvmppc_h_svm_page_out(struct kvm *kvm,
> > unsigned long gra,
> > unsigned long flags,
> > unsigned long page_shift);
> > +extern unsigned long kvmppc_h_svm_init_start(struct kvm *kvm);
> > +extern unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > #else
> > static inline unsigned long
> > kvmppc_h_svm_page_in(struct kvm *kvm, unsigned long gra,
> > @@ -25,5 +27,15 @@ kvmppc_h_svm_page_out(struct kvm *kvm, unsigned long gra,
> > {
> > return H_UNSUPPORTED;
> > }
> > +
> > +static inine unsigned long kvmppc_h_svm_init_start(struct kvm *kvm)
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > +
> > +static inine unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > #endif /* CONFIG_PPC_UV */
> > #endif /* __POWERPC_KVM_PPC_HMM_H__ */
>
> This patch won't build when CONFIG_PPC_UV isn't set because of two
> typos: "inine" and the ';' at the end of kvmppc_h_svm_init_done()
> function prototype.
Thanks. Fixed this.
Regards,
Bharata.
WARNING: multiple messages have this Message-ID (diff)
From: Bharata B Rao <bharata@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: linuxram@us.ibm.com, cclaudio@linux.ibm.com,
kvm-ppc@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com,
aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com,
sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls
Date: Tue, 9 Jul 2019 15:35:26 +0530 [thread overview]
Message-ID: <20190709100526.GC27933@in.ibm.com> (raw)
In-Reply-To: <87y31y7avd.fsf@morokweng.localdomain>
On Tue, Jun 18, 2019 at 08:05:26PM -0300, Thiago Jung Bauermann wrote:
>
> Hello Bharata,
>
> Bharata B Rao <bharata@linux.ibm.com> writes:
>
> > diff --git a/arch/powerpc/include/asm/kvm_book3s_hmm.h b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > index 21f3de5f2acb..3e13dab7f690 100644
> > --- a/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > +++ b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > @@ -11,6 +11,8 @@ extern unsigned long kvmppc_h_svm_page_out(struct kvm *kvm,
> > unsigned long gra,
> > unsigned long flags,
> > unsigned long page_shift);
> > +extern unsigned long kvmppc_h_svm_init_start(struct kvm *kvm);
> > +extern unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > #else
> > static inline unsigned long
> > kvmppc_h_svm_page_in(struct kvm *kvm, unsigned long gra,
> > @@ -25,5 +27,15 @@ kvmppc_h_svm_page_out(struct kvm *kvm, unsigned long gra,
> > {
> > return H_UNSUPPORTED;
> > }
> > +
> > +static inine unsigned long kvmppc_h_svm_init_start(struct kvm *kvm)
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > +
> > +static inine unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > #endif /* CONFIG_PPC_UV */
> > #endif /* __POWERPC_KVM_PPC_HMM_H__ */
>
> This patch won't build when CONFIG_PPC_UV isn't set because of two
> typos: "inine" and the ';' at the end of kvmppc_h_svm_init_done()
> function prototype.
Thanks. Fixed this.
Regards,
Bharata.
WARNING: multiple messages have this Message-ID (diff)
From: Bharata B Rao <bharata@linux.ibm.com>
To: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org,
linux-mm@kvack.org, paulus@au1.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com,
linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com,
cclaudio@linux.ibm.com
Subject: Re: [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls
Date: Tue, 9 Jul 2019 15:35:26 +0530 [thread overview]
Message-ID: <20190709100526.GC27933@in.ibm.com> (raw)
In-Reply-To: <87y31y7avd.fsf@morokweng.localdomain>
On Tue, Jun 18, 2019 at 08:05:26PM -0300, Thiago Jung Bauermann wrote:
>
> Hello Bharata,
>
> Bharata B Rao <bharata@linux.ibm.com> writes:
>
> > diff --git a/arch/powerpc/include/asm/kvm_book3s_hmm.h b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > index 21f3de5f2acb..3e13dab7f690 100644
> > --- a/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > +++ b/arch/powerpc/include/asm/kvm_book3s_hmm.h
> > @@ -11,6 +11,8 @@ extern unsigned long kvmppc_h_svm_page_out(struct kvm *kvm,
> > unsigned long gra,
> > unsigned long flags,
> > unsigned long page_shift);
> > +extern unsigned long kvmppc_h_svm_init_start(struct kvm *kvm);
> > +extern unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > #else
> > static inline unsigned long
> > kvmppc_h_svm_page_in(struct kvm *kvm, unsigned long gra,
> > @@ -25,5 +27,15 @@ kvmppc_h_svm_page_out(struct kvm *kvm, unsigned long gra,
> > {
> > return H_UNSUPPORTED;
> > }
> > +
> > +static inine unsigned long kvmppc_h_svm_init_start(struct kvm *kvm)
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > +
> > +static inine unsigned long kvmppc_h_svm_init_done(struct kvm *kvm);
> > +{
> > + return H_UNSUPPORTED;
> > +}
> > #endif /* CONFIG_PPC_UV */
> > #endif /* __POWERPC_KVM_PPC_HMM_H__ */
>
> This patch won't build when CONFIG_PPC_UV isn't set because of two
> typos: "inine" and the ';' at the end of kvmppc_h_svm_init_done()
> function prototype.
Thanks. Fixed this.
Regards,
Bharata.
next prev parent reply other threads:[~2019-07-09 10:17 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 6:49 [PATCH v4 0/6] kvmppc: HMM driver to manage pages of secure guest Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` [PATCH v4 1/6] kvmppc: HMM backend " Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-06-17 5:31 ` Paul Mackerras
2019-06-17 5:31 ` Paul Mackerras
2019-06-17 5:31 ` Paul Mackerras
2019-07-09 10:03 ` Bharata B Rao
2019-07-09 10:15 ` Bharata B Rao
2019-07-09 10:03 ` Bharata B Rao
2019-05-28 6:49 ` [PATCH v4 2/6] kvmppc: Shared pages support for secure guests Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` [PATCH v4 3/6] kvmppc: H_SVM_INIT_START and H_SVM_INIT_DONE hcalls Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-06-17 5:37 ` Paul Mackerras
2019-06-17 5:37 ` Paul Mackerras
2019-06-17 5:37 ` Paul Mackerras
2019-07-09 10:04 ` Bharata B Rao
2019-07-09 10:16 ` Bharata B Rao
2019-07-09 10:04 ` Bharata B Rao
2019-06-18 23:05 ` Thiago Jung Bauermann
2019-06-18 23:05 ` Thiago Jung Bauermann
2019-06-18 23:05 ` Thiago Jung Bauermann
2019-07-09 10:05 ` Bharata B Rao [this message]
2019-07-09 10:17 ` Bharata B Rao
2019-07-09 10:05 ` Bharata B Rao
2019-05-28 6:49 ` [PATCH v4 4/6] kvmppc: Handle memory plug/unplug to secure VM Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-06-17 5:38 ` Paul Mackerras
2019-06-17 5:38 ` Paul Mackerras
2019-06-17 5:38 ` Paul Mackerras
2019-05-28 6:49 ` [RFC PATCH v4 5/6] kvmppc: Radix changes for secure guest Bharata B Rao
2019-05-28 6:50 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-05-28 6:49 ` [RFC PATCH v4 6/6] kvmppc: Support reset of " Bharata B Rao
2019-05-28 6:50 ` Bharata B Rao
2019-05-28 6:49 ` Bharata B Rao
2019-06-17 4:06 ` Paul Mackerras
2019-06-17 4:06 ` Paul Mackerras
2019-06-17 4:06 ` Paul Mackerras
2019-07-09 10:06 ` Bharata B Rao
2019-07-09 10:18 ` Bharata B Rao
2019-07-09 10:06 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709100526.GC27933@in.ibm.com \
--to=bharata@linux.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=cclaudio@linux.ibm.com \
--cc=jglisse@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=paulus@au1.ibm.com \
--cc=sukadev@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.