From: Matthias Kaehlcke <mka@chromium.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
Date: Tue, 09 Jul 2019 14:52:24 +0000 [thread overview]
Message-ID: <20190709145224.GO250418@google.com> (raw)
In-Reply-To: <20190709013530.11865-1-weiyongjun1@huawei.com>
On Tue, Jul 09, 2019 at 01:35:30AM +0000, Wei Yongjun wrote:
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 9a5c9c1f9484..cbae86e55aed 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
> if (hdr->evt = HCI_EV_VENDOR)
> complete(&qca->drop_ev_comp);
>
> - kfree(skb);
> + kfree_skb(skb);
>
> return 0;
> }
Good catch, thanks!
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Kaehlcke <mka@chromium.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree()
Date: Tue, 9 Jul 2019 07:52:24 -0700 [thread overview]
Message-ID: <20190709145224.GO250418@google.com> (raw)
In-Reply-To: <20190709013530.11865-1-weiyongjun1@huawei.com>
On Tue, Jul 09, 2019 at 01:35:30AM +0000, Wei Yongjun wrote:
> Use kfree_skb() instead of kfree() to free sk_buff.
>
> Fixes: 2faa3f15fa2f ("Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/bluetooth/hci_qca.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 9a5c9c1f9484..cbae86e55aed 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -909,7 +909,7 @@ static int qca_recv_event(struct hci_dev *hdev, struct sk_buff *skb)
> if (hdr->evt == HCI_EV_VENDOR)
> complete(&qca->drop_ev_comp);
>
> - kfree(skb);
> + kfree_skb(skb);
>
> return 0;
> }
Good catch, thanks!
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
next prev parent reply other threads:[~2019-07-09 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 1:35 [PATCH -next] Bluetooth: hci_qca: Use kfree_skb() instead of kfree() Wei Yongjun
2019-07-09 1:35 ` Wei Yongjun
2019-07-09 14:52 ` Matthias Kaehlcke [this message]
2019-07-09 14:52 ` Matthias Kaehlcke
2019-07-11 7:07 ` Marcel Holtmann
2019-07-11 7:07 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709145224.GO250418@google.com \
--to=mka@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.