From: Rob Herring <robh@kernel.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
linux-renesas-soc@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>,
robh+dt@kernel.org
Subject: Re: [PATCH 8/8] dt-bindings: timer: renesas, cmt: Update R-Car Gen3 CMT1 usage
Date: Tue, 9 Jul 2019 10:26:47 -0600 [thread overview]
Message-ID: <20190709162647.GA15846@bogus> (raw)
In-Reply-To: <156076224112.4736.5038116002723317642.sendpatchset@octo>
On Mon, 17 Jun 2019 18:04:01 +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> The R-Car Gen3 SoCs so far come with a total for 4 on-chip CMT devices:
> - CMT0
> - CMT1
> - CMT2
> - CMT3
>
> CMT0 includes two rather basic 32-bit timer channels. The rest of the on-chip
> CMT devices support 48-bit counters and have 8 channels each.
>
> Based on the data sheet information "CMT2/3 are exactly same as CMT1"
> it seems that CMT2 and CMT3 now use the CMT1 compat string in the DTSI.
>
> Clarify this in the DT binding documentation by describing R-Car Gen3 and
> RZ/G2 CMT1 as "48-bit CMT devices".
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> Documentation/devicetree/bindings/timer/renesas,cmt.txt | 26 +++++++--------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> --- 0014/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> +++ work/Documentation/devicetree/bindings/timer/renesas,cmt.txt 2019-06-17 14:07:46.502422801 +0900
> @@ -28,9 +28,9 @@ Required Properties:
> - "renesas,r8a77470-cmt0" for the 32-bit CMT0 device included in r8a77470.
> - "renesas,r8a77470-cmt1" for the 48-bit CMT1 device included in r8a77470.
> - "renesas,r8a774a1-cmt0" for the 32-bit CMT0 device included in r8a774a1.
> - - "renesas,r8a774a1-cmt1" for the 48-bit CMT1 device included in r8a774a1.
> + - "renesas,r8a774a1-cmt1" for the 48-bit CMT devices included in r8a774a1.
> - "renesas,r8a774c0-cmt0" for the 32-bit CMT0 device included in r8a774c0.
> - - "renesas,r8a774c0-cmt1" for the 48-bit CMT1 device included in r8a774c0.
> + - "renesas,r8a774c0-cmt1" for the 48-bit CMT devices included in r8a774c0.
> - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790.
> - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790.
> - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791.
> @@ -42,34 +42,34 @@ Required Properties:
> - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
> - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
> - "renesas,r8a7795-cmt0" for the 32-bit CMT0 device included in r8a7795.
> - - "renesas,r8a7795-cmt1" for the 48-bit CMT1 device included in r8a7795.
> + - "renesas,r8a7795-cmt1" for the 48-bit CMT devices included in r8a7795.
> - "renesas,r8a7796-cmt0" for the 32-bit CMT0 device included in r8a7796.
> - - "renesas,r8a7796-cmt1" for the 48-bit CMT1 device included in r8a7796.
> + - "renesas,r8a7796-cmt1" for the 48-bit CMT devices included in r8a7796.
> - "renesas,r8a77965-cmt0" for the 32-bit CMT0 device included in r8a77965.
> - - "renesas,r8a77965-cmt1" for the 48-bit CMT1 device included in r8a77965.
> + - "renesas,r8a77965-cmt1" for the 48-bit CMT devices included in r8a77965.
> - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in r8a77970.
> - - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in r8a77970.
> + - "renesas,r8a77970-cmt1" for the 48-bit CMT devices included in r8a77970.
> - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in r8a77980.
> - - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in r8a77980.
> + - "renesas,r8a77980-cmt1" for the 48-bit CMT devices included in r8a77980.
> - "renesas,r8a77990-cmt0" for the 32-bit CMT0 device included in r8a77990.
> - - "renesas,r8a77990-cmt1" for the 48-bit CMT1 device included in r8a77990.
> + - "renesas,r8a77990-cmt1" for the 48-bit CMT devices included in r8a77990.
> - "renesas,r8a77995-cmt0" for the 32-bit CMT0 device included in r8a77995.
> - - "renesas,r8a77995-cmt1" for the 48-bit CMT1 device included in r8a77995.
> + - "renesas,r8a77995-cmt1" for the 48-bit CMT devices included in r8a77995.
> - "renesas,sh73a0-cmt0" for the 32-bit CMT0 device included in sh73a0.
> - "renesas,sh73a0-cmt1" for the 48-bit CMT1 device included in sh73a0.
> - "renesas,sh73a0-cmt2" for the 32-bit CMT2 device included in sh73a0.
> - "renesas,sh73a0-cmt3" for the 32-bit CMT3 device included in sh73a0.
> - "renesas,sh73a0-cmt4" for the 32-bit CMT4 device included in sh73a0.
>
> - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
> + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 device included in R-Car Gen2
> and RZ/G1.
> - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2
> + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 device included in R-Car Gen2
> and RZ/G1.
> These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 entries
> listed above.
> - - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car Gen3
> + - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 device included in R-Car Gen3
> and RZ/G2.
> - - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car Gen3
> + - "renesas,rcar-gen3-cmt1" for 48-bit CMT devices included in R-Car Gen3
> and RZ/G2.
> These are fallbacks for R-Car Gen3 and RZ/G2 entries listed
> above.
>
Reviewed-by: Rob Herring <robh@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: devicetree@vger.kernel.org, mark.rutland@arm.com,
linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org
Subject: Re: [PATCH 8/8] dt-bindings: timer: renesas, cmt: Update R-Car Gen3 CMT1 usage
Date: Tue, 9 Jul 2019 10:26:47 -0600 [thread overview]
Message-ID: <20190709162647.GA15846@bogus> (raw)
In-Reply-To: <156076224112.4736.5038116002723317642.sendpatchset@octo>
On Mon, 17 Jun 2019 18:04:01 +0900, Magnus Damm wrote:
> From: Magnus Damm <damm+renesas@opensource.se>
>
> The R-Car Gen3 SoCs so far come with a total for 4 on-chip CMT devices:
> - CMT0
> - CMT1
> - CMT2
> - CMT3
>
> CMT0 includes two rather basic 32-bit timer channels. The rest of the on-chip
> CMT devices support 48-bit counters and have 8 channels each.
>
> Based on the data sheet information "CMT2/3 are exactly same as CMT1"
> it seems that CMT2 and CMT3 now use the CMT1 compat string in the DTSI.
>
> Clarify this in the DT binding documentation by describing R-Car Gen3 and
> RZ/G2 CMT1 as "48-bit CMT devices".
>
> Signed-off-by: Magnus Damm <damm+renesas@opensource.se>
> ---
>
> Documentation/devicetree/bindings/timer/renesas,cmt.txt | 26 +++++++--------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> --- 0014/Documentation/devicetree/bindings/timer/renesas,cmt.txt
> +++ work/Documentation/devicetree/bindings/timer/renesas,cmt.txt 2019-06-17 14:07:46.502422801 +0900
> @@ -28,9 +28,9 @@ Required Properties:
> - "renesas,r8a77470-cmt0" for the 32-bit CMT0 device included in r8a77470.
> - "renesas,r8a77470-cmt1" for the 48-bit CMT1 device included in r8a77470.
> - "renesas,r8a774a1-cmt0" for the 32-bit CMT0 device included in r8a774a1.
> - - "renesas,r8a774a1-cmt1" for the 48-bit CMT1 device included in r8a774a1.
> + - "renesas,r8a774a1-cmt1" for the 48-bit CMT devices included in r8a774a1.
> - "renesas,r8a774c0-cmt0" for the 32-bit CMT0 device included in r8a774c0.
> - - "renesas,r8a774c0-cmt1" for the 48-bit CMT1 device included in r8a774c0.
> + - "renesas,r8a774c0-cmt1" for the 48-bit CMT devices included in r8a774c0.
> - "renesas,r8a7790-cmt0" for the 32-bit CMT0 device included in r8a7790.
> - "renesas,r8a7790-cmt1" for the 48-bit CMT1 device included in r8a7790.
> - "renesas,r8a7791-cmt0" for the 32-bit CMT0 device included in r8a7791.
> @@ -42,34 +42,34 @@ Required Properties:
> - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794.
> - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794.
> - "renesas,r8a7795-cmt0" for the 32-bit CMT0 device included in r8a7795.
> - - "renesas,r8a7795-cmt1" for the 48-bit CMT1 device included in r8a7795.
> + - "renesas,r8a7795-cmt1" for the 48-bit CMT devices included in r8a7795.
> - "renesas,r8a7796-cmt0" for the 32-bit CMT0 device included in r8a7796.
> - - "renesas,r8a7796-cmt1" for the 48-bit CMT1 device included in r8a7796.
> + - "renesas,r8a7796-cmt1" for the 48-bit CMT devices included in r8a7796.
> - "renesas,r8a77965-cmt0" for the 32-bit CMT0 device included in r8a77965.
> - - "renesas,r8a77965-cmt1" for the 48-bit CMT1 device included in r8a77965.
> + - "renesas,r8a77965-cmt1" for the 48-bit CMT devices included in r8a77965.
> - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in r8a77970.
> - - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in r8a77970.
> + - "renesas,r8a77970-cmt1" for the 48-bit CMT devices included in r8a77970.
> - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in r8a77980.
> - - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in r8a77980.
> + - "renesas,r8a77980-cmt1" for the 48-bit CMT devices included in r8a77980.
> - "renesas,r8a77990-cmt0" for the 32-bit CMT0 device included in r8a77990.
> - - "renesas,r8a77990-cmt1" for the 48-bit CMT1 device included in r8a77990.
> + - "renesas,r8a77990-cmt1" for the 48-bit CMT devices included in r8a77990.
> - "renesas,r8a77995-cmt0" for the 32-bit CMT0 device included in r8a77995.
> - - "renesas,r8a77995-cmt1" for the 48-bit CMT1 device included in r8a77995.
> + - "renesas,r8a77995-cmt1" for the 48-bit CMT devices included in r8a77995.
> - "renesas,sh73a0-cmt0" for the 32-bit CMT0 device included in sh73a0.
> - "renesas,sh73a0-cmt1" for the 48-bit CMT1 device included in sh73a0.
> - "renesas,sh73a0-cmt2" for the 32-bit CMT2 device included in sh73a0.
> - "renesas,sh73a0-cmt3" for the 32-bit CMT3 device included in sh73a0.
> - "renesas,sh73a0-cmt4" for the 32-bit CMT4 device included in sh73a0.
>
> - - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2
> + - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 device included in R-Car Gen2
> and RZ/G1.
> - - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 devices included in R-Car Gen2
> + - "renesas,rcar-gen2-cmt1" for 48-bit CMT1 device included in R-Car Gen2
> and RZ/G1.
> These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 entries
> listed above.
> - - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car Gen3
> + - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 device included in R-Car Gen3
> and RZ/G2.
> - - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car Gen3
> + - "renesas,rcar-gen3-cmt1" for 48-bit CMT devices included in R-Car Gen3
> and RZ/G2.
> These are fallbacks for R-Car Gen3 and RZ/G2 entries listed
> above.
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2019-07-09 16:26 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 9:02 [PATCH 0/8] dt-bindings: timer: renesas, cmt: Various updates Magnus Damm
2019-06-17 9:02 ` [PATCH 1/8] dt-bindings: timer: renesas, cmt: Add CMT0234 to sh73a0 and r8a7740 Magnus Damm
2019-07-09 16:21 ` Rob Herring
2019-07-09 16:21 ` Rob Herring
2019-06-17 9:03 ` [PATCH 2/8] dt-bindings: timer: renesas, cmt: Update CMT1 on " Magnus Damm
2019-07-09 16:23 ` Rob Herring
2019-07-09 16:23 ` Rob Herring
2019-06-17 9:03 ` [PATCH 3/8] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a7792 Magnus Damm
2019-06-18 12:58 ` Geert Uytterhoeven
2019-07-09 16:23 ` Rob Herring
2019-07-09 16:23 ` Rob Herring
2019-06-17 9:03 ` [PATCH 4/8] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a7795 Magnus Damm
2019-06-18 13:00 ` Geert Uytterhoeven
2019-07-09 16:23 ` Rob Herring
2019-07-09 16:23 ` Rob Herring
2019-06-17 9:03 ` [PATCH 5/8] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a77965 Magnus Damm
2019-06-18 13:01 ` Geert Uytterhoeven
2019-07-09 16:23 ` Rob Herring
2019-07-09 16:23 ` Rob Herring
2019-06-17 9:03 ` [PATCH 6/8] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a77990 Magnus Damm
2019-06-18 13:02 ` Geert Uytterhoeven
2019-07-09 16:25 ` Rob Herring
2019-07-09 16:25 ` Rob Herring
2019-06-17 9:03 ` [PATCH 7/8] dt-bindings: timer: renesas, cmt: Add CMT0 and CMT1 to r8a77995 Magnus Damm
2019-06-18 13:02 ` Geert Uytterhoeven
2019-07-09 16:25 ` Rob Herring
2019-07-09 16:25 ` Rob Herring
2019-06-17 9:04 ` [PATCH 8/8] dt-bindings: timer: renesas, cmt: Update R-Car Gen3 CMT1 usage Magnus Damm
2019-06-18 13:06 ` Geert Uytterhoeven
2019-07-09 16:26 ` Rob Herring [this message]
2019-07-09 16:26 ` Rob Herring
2019-06-18 10:31 ` [PATCH 0/8] dt-bindings: timer: renesas, cmt: Various updates Simon Horman
2019-06-18 12:25 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709162647.GA15846@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.