From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Zeng Tao <prime.zeng@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, kishon@ti.com,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: Change the configuration interface param to void* to make it more general
Date: Fri, 12 Jul 2019 09:21:45 +0200 [thread overview]
Message-ID: <20190712072145.gr3dbfvdfgrye6yi@flea> (raw)
In-Reply-To: <1562923580-47746-1-git-send-email-prime.zeng@hisilicon.com>
[-- Attachment #1.1: Type: text/plain, Size: 738 bytes --]
On Fri, Jul 12, 2019 at 05:26:04PM +0800, Zeng Tao wrote:
> The phy framework now allows runtime configurations, but only limited
> to mipi now, and it's not reasonable to introduce user specified
> configurations into the union phy_configure_opts structure. An simple
> way is to replace with a void *.
>
> We have already got some phy drivers which introduce private phy API
> for runtime configurations, and with this patch, they can switch to
> the phy_configure as a replace.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
I still don't believe this is the right approach, for the reasons
exposed in my first review of that patch.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Zeng Tao <prime.zeng@hisilicon.com>
Cc: kishon@ti.com, Chen-Yu Tsai <wens@csie.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] phy: Change the configuration interface param to void* to make it more general
Date: Fri, 12 Jul 2019 09:21:45 +0200 [thread overview]
Message-ID: <20190712072145.gr3dbfvdfgrye6yi@flea> (raw)
In-Reply-To: <1562923580-47746-1-git-send-email-prime.zeng@hisilicon.com>
[-- Attachment #1: Type: text/plain, Size: 738 bytes --]
On Fri, Jul 12, 2019 at 05:26:04PM +0800, Zeng Tao wrote:
> The phy framework now allows runtime configurations, but only limited
> to mipi now, and it's not reasonable to introduce user specified
> configurations into the union phy_configure_opts structure. An simple
> way is to replace with a void *.
>
> We have already got some phy drivers which introduce private phy API
> for runtime configurations, and with this patch, they can switch to
> the phy_configure as a replace.
>
> Signed-off-by: Zeng Tao <prime.zeng@hisilicon.com>
I still don't believe this is the right approach, for the reasons
exposed in my first review of that patch.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-07-12 7:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 9:26 [PATCH] phy: Change the configuration interface param to void* to make it more general Zeng Tao
2019-07-12 9:26 ` Zeng Tao
2019-07-12 7:21 ` Maxime Ripard [this message]
2019-07-12 7:21 ` Maxime Ripard
2019-07-13 20:22 ` Sakari Ailus
2019-07-13 20:22 ` Sakari Ailus
-- strict thread matches above, loose matches on Subject: below --
2019-07-11 18:04 Zeng Tao
2019-07-11 18:04 ` Zeng Tao
2019-07-11 11:20 ` Maxime Ripard
2019-07-11 11:20 ` Maxime Ripard
2019-07-17 6:36 ` Zengtao (B)
2019-07-17 6:36 ` Zengtao (B)
2019-07-17 16:37 ` Maxime Ripard
2019-07-17 16:37 ` Maxime Ripard
2019-07-20 3:03 ` Zengtao (B)
2019-07-20 3:03 ` Zengtao (B)
2019-07-24 8:52 ` Maxime Ripard
2019-07-24 8:52 ` Maxime Ripard
2019-07-13 23:21 ` kbuild test robot
2019-07-14 12:45 ` kbuild test robot
2019-07-14 12:45 ` kbuild test robot
2019-07-19 21:07 ` kbuild test robot
2019-08-08 22:01 ` kbuild test robot
2019-08-08 22:01 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190712072145.gr3dbfvdfgrye6yi@flea \
--to=maxime.ripard@bootlin.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=prime.zeng@hisilicon.com \
--cc=sakari.ailus@linux.intel.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.