* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-12 16:21 ` Sam Ravnborg
0 siblings, 0 replies; 14+ messages in thread
From: Sam Ravnborg @ 2019-07-12 16:21 UTC (permalink / raw)
To: Nicolas.Ferre, Joshua Henderson
Cc: Joshua.Henderson, bbrezillon, airlied, alexandre.belloni,
linux-arm-kernel, dri-devel, linux-kernel
Hi Joshua.
On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > This bit enables replication logic to expand an RGB color less than 24
> > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > the least significant bits are always set to zero and the color may not
> > be what is expected.
> >
> > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> Here is patchwork entry:
> https://patchwork.kernel.org/patch/11037167/
>
> Thanks, best regards,
> Nicolas
>
> > ---
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index eb7c4cf..6f6cf61 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > cfg);
> >
> > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> >
> > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
Thanks - this gave me an opportunity to read a bit more in the datasheet
of the controller.
Applied to drm-misc-next with Ack from Nicolas.
Sam
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-12 16:21 ` Sam Ravnborg
(?)
@ 2019-07-12 16:27 ` Boris Brezillon
-1 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:27 UTC (permalink / raw)
To: Sam Ravnborg
Cc: alexandre.belloni, bbrezillon, airlied, Joshua Henderson,
dri-devel, linux-kernel, linux-arm-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
I was about to add my R-b and ask you to apply the patch :-). I'm glad
you didn't wait for my feedback to apply the fix, that means I'll be
able to remove my name from the Atmel HLCDC entry soon ;-).
>
> Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-12 16:27 ` Boris Brezillon
0 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:27 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Nicolas.Ferre, Joshua Henderson, bbrezillon, airlied,
alexandre.belloni, linux-arm-kernel, dri-devel, linux-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
I was about to add my R-b and ask you to apply the patch :-). I'm glad
you didn't wait for my feedback to apply the fix, that means I'll be
able to remove my name from the Atmel HLCDC entry soon ;-).
>
> Sam
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-12 16:27 ` Boris Brezillon
0 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:27 UTC (permalink / raw)
To: Sam Ravnborg
Cc: alexandre.belloni, bbrezillon, airlied, Joshua Henderson,
Nicolas.Ferre, dri-devel, linux-kernel, linux-arm-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
I was about to add my R-b and ask you to apply the patch :-). I'm glad
you didn't wait for my feedback to apply the fix, that means I'll be
able to remove my name from the Atmel HLCDC entry soon ;-).
>
> Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
2019-07-12 16:21 ` Sam Ravnborg
(?)
@ 2019-07-12 16:32 ` Boris Brezillon
-1 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: alexandre.belloni, bbrezillon, airlied, Joshua Henderson,
dri-devel, linux-kernel, linux-arm-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
Was about to add my R-b and ask you to apply the patch. I'm glad you
didn't wait for my feedback though, that means I'll soon be able to
remove my name from the Atmel HLCDC entry in MAINTAINERS ;-).
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-12 16:32 ` Boris Brezillon
0 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: Nicolas.Ferre, Joshua Henderson, bbrezillon, airlied,
alexandre.belloni, linux-arm-kernel, dri-devel, linux-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
Was about to add my R-b and ask you to apply the patch. I'm glad you
didn't wait for my feedback though, that means I'll soon be able to
remove my name from the Atmel HLCDC entry in MAINTAINERS ;-).
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH] drm/atmel-hlcdc: set layer REP bit to enable replication logic
@ 2019-07-12 16:32 ` Boris Brezillon
0 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-07-12 16:32 UTC (permalink / raw)
To: Sam Ravnborg
Cc: alexandre.belloni, bbrezillon, airlied, Joshua Henderson,
Nicolas.Ferre, dri-devel, linux-kernel, linux-arm-kernel
On Fri, 12 Jul 2019 18:21:17 +0200
Sam Ravnborg <sam@ravnborg.org> wrote:
> Hi Joshua.
>
> On Tue, Jul 09, 2019 at 04:24:49PM +0000, Nicolas.Ferre@microchip.com wrote:
> > On 09/07/2019 at 17:35, Joshua Henderson wrote:
> > > This bit enables replication logic to expand an RGB color less than 24
> > > bits, to 24 bits, which is used internally for all formats. Otherwise,
> > > the least significant bits are always set to zero and the color may not
> > > be what is expected.
> > >
> > > Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com>
> >
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> >
> > Here is patchwork entry:
> > https://patchwork.kernel.org/patch/11037167/
> >
> > Thanks, best regards,
> > Nicolas
> >
> > > ---
> > > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > index eb7c4cf..6f6cf61 100644
> > > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > > @@ -389,7 +389,7 @@ atmel_hlcdc_plane_update_general_settings(struct atmel_hlcdc_plane *plane,
> > > atmel_hlcdc_layer_write_cfg(&plane->layer, ATMEL_HLCDC_LAYER_DMA_CFG,
> > > cfg);
> > >
> > > - cfg = ATMEL_HLCDC_LAYER_DMA;
> > > + cfg = ATMEL_HLCDC_LAYER_DMA | ATMEL_HLCDC_LAYER_REP;
> > >
> > > if (plane->base.type != DRM_PLANE_TYPE_PRIMARY) {
> > > cfg |= ATMEL_HLCDC_LAYER_OVR | ATMEL_HLCDC_LAYER_ITER2BL |
>
> Thanks - this gave me an opportunity to read a bit more in the datasheet
> of the controller.
> Applied to drm-misc-next with Ack from Nicolas.
Was about to add my R-b and ask you to apply the patch. I'm glad you
didn't wait for my feedback though, that means I'll soon be able to
remove my name from the Atmel HLCDC entry in MAINTAINERS ;-).
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread