From: Vladimir Oltean <olteanv@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 1/9] net: tsec: Refactor the readout of the tbi-handle property
Date: Sun, 14 Jul 2019 03:16:53 +0300 [thread overview]
Message-ID: <20190714001701.2781-2-olteanv@gmail.com> (raw)
In-Reply-To: <20190714001701.2781-1-olteanv@gmail.com>
The point of this patch is to eliminate the use of the locally-defined
"reg" variable (which interferes with next patch) and simplify the
fallback to the default CONFIG_SYS_TBIPA_VALUE in case "tbi-handle" is
missing.
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
---
Changes from v1:
None.
drivers/net/tsec.c | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 06a9b4fb03ce..53eb5470f4c8 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -798,6 +798,7 @@ int tsec_probe(struct udevice *dev)
struct eth_pdata *pdata = dev_get_platdata(dev);
struct fsl_pq_mdio_info mdio_info;
struct ofnode_phandle_args phandle_args;
+ u32 tbiaddr = CONFIG_SYS_TBIPA_VALUE;
ofnode parent;
const char *phy_mode;
int ret;
@@ -825,14 +826,12 @@ int tsec_probe(struct udevice *dev)
return -ENOENT;
}
- if (dev_read_phandle_with_args(dev, "tbi-handle", NULL, 0, 0,
- &phandle_args)) {
- priv->tbiaddr = CONFIG_SYS_TBIPA_VALUE;
- } else {
- int reg = ofnode_read_u32_default(phandle_args.node, "reg",
- CONFIG_SYS_TBIPA_VALUE);
- priv->tbiaddr = reg;
- }
+ ret = dev_read_phandle_with_args(dev, "tbi-handle", NULL, 0, 0,
+ &phandle_args);
+ if (ret == 0)
+ ofnode_read_u32(phandle_args.node, "reg", &tbiaddr);
+
+ priv->tbiaddr = tbiaddr;
phy_mode = dev_read_prop(dev, "phy-connection-type", NULL);
if (phy_mode)
--
2.17.1
next prev parent reply other threads:[~2019-07-14 0:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 0:16 [U-Boot] [PATCH v2 0/9] NXP LS1021A-TSN Board Vladimir Oltean
2019-07-14 0:16 ` Vladimir Oltean [this message]
2019-07-14 0:16 ` [U-Boot] [PATCH v2 2/9] net: tsec: Fix offset of MDIO registers for DM_ETH Vladimir Oltean
2019-07-14 2:07 ` Bin Meng
2019-07-14 0:16 ` [U-Boot] [PATCH v2 3/9] net: tsec: Reverse Christmas tree notation Vladimir Oltean
2019-07-14 0:16 ` [U-Boot] [PATCH v2 4/9] net: tsec: Make errors visible Vladimir Oltean
2019-07-14 0:16 ` [U-Boot] [PATCH v2 5/9] net: tsec: Common handling of MAC station address for DM_ETH Vladimir Oltean
2019-07-14 0:16 ` [U-Boot] [PATCH v2 6/9] net: tsec: Change compatible strings to match Linux Vladimir Oltean
2019-07-14 2:08 ` Bin Meng
2019-07-14 0:16 ` [U-Boot] [PATCH v2 7/9] arm: ls1021atwr: Convert to use driver model TSEC driver Vladimir Oltean
2019-07-14 0:17 ` [U-Boot] [PATCH v2 8/9] configs: ls1021atwr: Fix distro_bootcmd for QSPI boot Vladimir Oltean
2019-07-15 18:49 ` Joe Hershberger
2019-07-14 0:17 ` [U-Boot] [PATCH v2 9/9] Add support for the NXP LS1021A-TSN board Vladimir Oltean
2019-07-14 2:09 ` Bin Meng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714001701.2781-2-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.