From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: [PATCH v2 3/5] ima-evm-utils: Fix memory leak in get_password
Date: Mon, 15 Jul 2019 23:05:51 +0300 [thread overview]
Message-ID: <20190715200553.22403-3-vt@altlinux.org> (raw)
In-Reply-To: <20190715200553.22403-1-vt@altlinux.org>
Free allocated password buffer when returning NULL.
Fixes: CID 229894 (partially).
---
src/evmctl.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/evmctl.c b/src/evmctl.c
index 04dc546..f15056b 100644
--- a/src/evmctl.c
+++ b/src/evmctl.c
@@ -1841,6 +1841,7 @@ static char *get_password(void)
if (tcsetattr(fileno(stdin), TCSANOW, &tmp_flags) != 0) {
perror("tcsetattr");
+ free(password);
return NULL;
}
@@ -1850,6 +1851,7 @@ static char *get_password(void)
/* restore terminal */
if (tcsetattr(fileno(stdin), TCSANOW, &flags) != 0) {
perror("tcsetattr");
+ free(password);
return NULL;
}
--
2.11.0
next prev parent reply other threads:[~2019-07-15 20:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:05 [PATCH v2 1/5] ima-evm-utils: Fix null dereference from file2bin to memcpy Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 2/5] ima-evm-utils: Fix possible xattr_value overflows in calc_evm_hash Vitaly Chikunov
2019-07-15 20:05 ` Vitaly Chikunov [this message]
2019-07-15 20:05 ` [PATCH v2 4/5] ima-evm-utils: Fix file2bin stat and fopen relations Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 5/5] ima-evm-utils: Add more error checking in add_file_hash Vitaly Chikunov
2019-07-16 14:46 ` [PATCH v2 1/5] ima-evm-utils: Fix null dereference from file2bin to memcpy Mimi Zohar
2019-07-16 14:59 ` Vitaly Chikunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190715200553.22403-3-vt@altlinux.org \
--to=vt@altlinux.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.