From: Vitaly Chikunov <vt@altlinux.org>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
linux-integrity@vger.kernel.org
Subject: Re: [PATCH v2 1/5] ima-evm-utils: Fix null dereference from file2bin to memcpy
Date: Tue, 16 Jul 2019 17:59:15 +0300 [thread overview]
Message-ID: <20190716145915.s5cng2cr5eb46ulx@altlinux.org> (raw)
In-Reply-To: <1563288418.4539.228.camel@linux.ibm.com>
Mimi,
On Tue, Jul 16, 2019 at 10:46:58AM -0400, Mimi Zohar wrote:
> On Mon, 2019-07-15 at 23:05 +0300, Vitaly Chikunov wrote:
> > file2bin() may return NULL, which is set to tmp, which is passed to
> > memcpy. Add explicit check for it.
> >
> > Fixes: CID 229904.
>
> Other than the missing tag, this and the other patches look good.
Sorry I forgot to add Signed-off-by tag. You may add to all these commits:
Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
Thanks,
>
> thanks!
>
> Mimi
prev parent reply other threads:[~2019-07-16 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 20:05 [PATCH v2 1/5] ima-evm-utils: Fix null dereference from file2bin to memcpy Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 2/5] ima-evm-utils: Fix possible xattr_value overflows in calc_evm_hash Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 3/5] ima-evm-utils: Fix memory leak in get_password Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 4/5] ima-evm-utils: Fix file2bin stat and fopen relations Vitaly Chikunov
2019-07-15 20:05 ` [PATCH v2 5/5] ima-evm-utils: Add more error checking in add_file_hash Vitaly Chikunov
2019-07-16 14:46 ` [PATCH v2 1/5] ima-evm-utils: Fix null dereference from file2bin to memcpy Mimi Zohar
2019-07-16 14:59 ` Vitaly Chikunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716145915.s5cng2cr5eb46ulx@altlinux.org \
--to=vt@altlinux.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=linux-integrity@vger.kernel.org \
--cc=zohar@linux.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.