Re: [PATCH] 30_os-prober: Provide GRUB_OS_PROBER_DISABLE_DEBUG

[Michael Chang <MChang@suse.com>]

On Mon, Jul 15, 2019 at 05:26:55PM +0100, Colin Watson wrote:
> On Mon, Jul 15, 2019 at 09:28:31AM +0000, Michael Chang wrote:
> > This patch adds support to disable os-prober debug output while running
> > grub-mkconfig through GRUB_OS_PROBER_DISABLE_DEBUG=true in simple
> > configuration interface. The os-prober needs to support the
> > OS_PROBER_DISABLE_DEBUG environment variable, which was introduced by
> > 1.72 release.
> 
> Rather than extending the /etc/default/grub configuration interface for
> this, I wonder if it would be better to just do something like this in
> 30_os-prober:
> 
>   export OS_PROBER_DISABLE_DEBUG="${OS_PROBER_DISABLE_DEBUG-y}"
> 
> That way, people who want details can set OS_PROBER_DISABLE_DEBUG= (i.e.
> empty) when running grub-mkconfig, or we could add a --debug option or
> something; but otherwise debug output will be suppressed, which seems
> like a better default for grub-mkconfig.

What about changing the os-prober default to disable the debug output ?
In that way we don't need to patch grub, just do this to enable it.

 export OS_PROBER_ENABLE_DEBUG=y; grub-mkconfig

Btw, the intention of using /etc/default/grub is to make the change
persistent to os-prober as it has no settings for that, and is in a
documented way. I'm fine doing it either way, because the thing here is
to suppress os-prober debug output as default, and re-enable it by
settings or command line interface are all viable imho.

Thanks,
Michael

> 
> -- 
> Colin Watson                                       [cjwatson@ubuntu.com]
> 
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel