From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, linux-input@vger.kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource()
Date: Tue, 16 Jul 2019 09:30:44 +0200 [thread overview]
Message-ID: <20190716073044.GA1182@penguin> (raw)
In-Reply-To: <1554362243-2888-2-git-send-email-mojha@codeaurora.org>
On Thu, Apr 04, 2019 at 12:47:19PM +0530, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index 1d6c8f4..b66df8a 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -503,7 +503,6 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct mx25_tcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(dev->parent);
> - struct resource *res;
> void __iomem *mem;
> int error;
>
> @@ -512,8 +511,7 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> return -ENOMEM;
> priv->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
linux-imx@nxp.com, linux-input@vger.kernel.org,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource()
Date: Tue, 16 Jul 2019 09:30:44 +0200 [thread overview]
Message-ID: <20190716073044.GA1182@penguin> (raw)
In-Reply-To: <1554362243-2888-2-git-send-email-mojha@codeaurora.org>
On Thu, Apr 04, 2019 at 12:47:19PM +0530, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index 1d6c8f4..b66df8a 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -503,7 +503,6 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct mx25_tcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(dev->parent);
> - struct resource *res;
> void __iomem *mem;
> int error;
>
> @@ -512,8 +511,7 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> return -ENOMEM;
> priv->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
--
Dmitry
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, linux-imx@nxp.com,
linux-input@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] Input: fsl-imx25-tcq: Use devm_platform_ioremap_resource()
Date: Tue, 16 Jul 2019 09:30:44 +0200 [thread overview]
Message-ID: <20190716073044.GA1182@penguin> (raw)
In-Reply-To: <1554362243-2888-2-git-send-email-mojha@codeaurora.org>
On Thu, Apr 04, 2019 at 12:47:19PM +0530, Mukesh Ojha wrote:
> devm_platform_ioremap_resource() internally have platform_get_resource()
> and devm_ioremap_resource() in it. So instead of calling them separately
> use devm_platform_ioremap_resource() directly.
>
> Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/fsl-imx25-tcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/input/touchscreen/fsl-imx25-tcq.c b/drivers/input/touchscreen/fsl-imx25-tcq.c
> index 1d6c8f4..b66df8a 100644
> --- a/drivers/input/touchscreen/fsl-imx25-tcq.c
> +++ b/drivers/input/touchscreen/fsl-imx25-tcq.c
> @@ -503,7 +503,6 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> struct input_dev *idev;
> struct mx25_tcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(dev->parent);
> - struct resource *res;
> void __iomem *mem;
> int error;
>
> @@ -512,8 +511,7 @@ static int mx25_tcq_probe(struct platform_device *pdev)
> return -ENOMEM;
> priv->dev = dev;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center,
> Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
--
Dmitry
next prev parent reply other threads:[~2019-07-16 7:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 7:17 [PATCH 0/5] Input: Use devm_platform_ioremap_resource() Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-04-04 7:17 ` [PATCH 1/5] Input: fsl-imx25-tcq: " Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-07-16 7:30 ` Dmitry Torokhov [this message]
2019-07-16 7:30 ` Dmitry Torokhov
2019-07-16 7:30 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 2/5] Input: mxs-lradc-ts.c: " Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-07-16 7:32 ` Dmitry Torokhov
2019-07-16 7:32 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 3/5] Input: s3c2410_ts: " Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-07-16 7:39 ` Dmitry Torokhov
2019-07-16 7:39 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 4/5] Input: sun4i-ts: " Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-07-16 7:34 ` Dmitry Torokhov
2019-07-16 7:34 ` Dmitry Torokhov
2019-04-04 7:17 ` [PATCH 5/5] Input: ts4800-ts: " Mukesh Ojha
2019-04-04 7:17 ` Mukesh Ojha
2019-07-16 7:34 ` Dmitry Torokhov
2019-07-16 7:34 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716073044.GA1182@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.