From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Grzegorz Jaszczyk <jaz@semihalf.com>,
lorenzo.pieralisi@arm.com, bhelgaas@google.com,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
mw@semihalf.com
Subject: Re: [PATCH] PCI: aardvark: fix big endian support
Date: Tue, 16 Jul 2019 08:32:04 +0200 [thread overview]
Message-ID: <20190716083204.375afc1e@windsurf> (raw)
In-Reply-To: <20190715151016.6amymuikizmmmsph@shell.armlinux.org.uk>
Hello,
On Mon, 15 Jul 2019 16:10:16 +0100
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> > Also, the advk_pci_bridge_emul_pcie_conf_read() and
> > advk_pci_bridge_emul_pcie_conf_write() return values that are in the
> > CPU endianness.
> >
> > Am I missing something ?
>
> Getting the types correct and then using Sparse to validate the code
> will help to identify issues exactly like this.
Yes, I absolutely agree with your recommendation on the other thread.
In fact, I am wondering if it really makes sense to store the "fake"
config space in LE, since anyway the read/write accessors should return
values in the CPU endianness.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: lorenzo.pieralisi@arm.com, Grzegorz Jaszczyk <jaz@semihalf.com>,
linux-pci@vger.kernel.org, bhelgaas@google.com, mw@semihalf.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: aardvark: fix big endian support
Date: Tue, 16 Jul 2019 08:32:04 +0200 [thread overview]
Message-ID: <20190716083204.375afc1e@windsurf> (raw)
In-Reply-To: <20190715151016.6amymuikizmmmsph@shell.armlinux.org.uk>
Hello,
On Mon, 15 Jul 2019 16:10:16 +0100
Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote:
> > Also, the advk_pci_bridge_emul_pcie_conf_read() and
> > advk_pci_bridge_emul_pcie_conf_write() return values that are in the
> > CPU endianness.
> >
> > Am I missing something ?
>
> Getting the types correct and then using Sparse to validate the code
> will help to identify issues exactly like this.
Yes, I absolutely agree with your recommendation on the other thread.
In fact, I am wondering if it really makes sense to store the "fake"
config space in LE, since anyway the read/write accessors should return
values in the CPU endianness.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-16 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-15 14:15 [PATCH] PCI: aardvark: fix big endian support Grzegorz Jaszczyk
2019-07-15 14:15 ` Grzegorz Jaszczyk
2019-07-15 15:08 ` Thomas Petazzoni
2019-07-15 15:08 ` Thomas Petazzoni
2019-07-15 15:10 ` Russell King - ARM Linux admin
2019-07-15 15:10 ` Russell King - ARM Linux admin
2019-07-16 6:32 ` Thomas Petazzoni [this message]
2019-07-16 6:32 ` Thomas Petazzoni
2019-07-16 8:56 ` Russell King - ARM Linux admin
2019-07-16 8:56 ` Russell King - ARM Linux admin
2019-07-16 8:31 ` Grzegorz Jaszczyk
2019-07-16 8:31 ` Grzegorz Jaszczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716083204.375afc1e@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=bhelgaas@google.com \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mw@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.