From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller
Date: Tue, 16 Jul 2019 14:05:47 +0200 [thread overview]
Message-ID: <20190716120547.GA2388@lst.de> (raw)
In-Reply-To: <bfbc7352951d1adc714f699acb49e298c24fe7e3.camel@kernel.crashing.org>
On Tue, Jul 16, 2019@08:58:28PM +1000, Benjamin Herrenschmidt wrote:
> The main risk is if existing controllers return crap in SQES and we try
> to then use that crap. The rest should essentially be NOPs.
>
> Maybe I should add some kind of printk to warn in case we use/detect a
> non-standard size. That would help diagnosing issues.
Given that the spec currently requires bits 0 to 3 of SQES to be 6
we might as well not check SQES and just hardcode it to 6 or 7 depending
on the quirk. That actually was my initial idea, I just suggested using
the SQES naming and indexing.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
Paul Pawlowski <paul@mrarm.io>
Subject: Re: [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller
Date: Tue, 16 Jul 2019 14:05:47 +0200 [thread overview]
Message-ID: <20190716120547.GA2388@lst.de> (raw)
In-Reply-To: <bfbc7352951d1adc714f699acb49e298c24fe7e3.camel@kernel.crashing.org>
On Tue, Jul 16, 2019 at 08:58:28PM +1000, Benjamin Herrenschmidt wrote:
> The main risk is if existing controllers return crap in SQES and we try
> to then use that crap. The rest should essentially be NOPs.
>
> Maybe I should add some kind of printk to warn in case we use/detect a
> non-standard size. That would help diagnosing issues.
Given that the spec currently requires bits 0 to 3 of SQES to be 6
we might as well not check SQES and just hardcode it to 6 or 7 depending
on the quirk. That actually was my initial idea, I just suggested using
the SQES naming and indexing.
next prev parent reply other threads:[~2019-07-16 12:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 0:46 [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros Benjamin Herrenschmidt
2019-07-16 0:46 ` Benjamin Herrenschmidt
2019-07-16 0:46 ` [PATCH 2/3] nvme: Retrieve the required IO queue entry size from the controller Benjamin Herrenschmidt
2019-07-16 0:46 ` Benjamin Herrenschmidt
2019-07-16 6:04 ` Christoph Hellwig
2019-07-16 6:04 ` Christoph Hellwig
2019-07-16 6:21 ` Benjamin Herrenschmidt
2019-07-16 6:21 ` Benjamin Herrenschmidt
2019-07-16 9:33 ` Christoph Hellwig
2019-07-16 9:33 ` Christoph Hellwig
2019-07-16 10:58 ` Benjamin Herrenschmidt
2019-07-16 10:58 ` Benjamin Herrenschmidt
2019-07-16 12:05 ` Christoph Hellwig [this message]
2019-07-16 12:05 ` Christoph Hellwig
2019-07-16 12:17 ` Benjamin Herrenschmidt
2019-07-16 12:17 ` Benjamin Herrenschmidt
2019-07-16 12:25 ` Christoph Hellwig
2019-07-16 12:25 ` Christoph Hellwig
2019-07-16 0:46 ` [PATCH 3/3] nvme: Add support for Apple 2018+ models Benjamin Herrenschmidt
2019-07-16 0:46 ` Benjamin Herrenschmidt
2019-07-16 6:06 ` Christoph Hellwig
2019-07-16 6:06 ` Christoph Hellwig
2019-07-16 6:22 ` Benjamin Herrenschmidt
2019-07-16 6:22 ` Benjamin Herrenschmidt
2019-07-16 0:49 ` [PATCH 1/3] nvme: Pass the queue to SQ_SIZE/CQ_SIZE macros Benjamin Herrenschmidt
2019-07-16 0:49 ` Benjamin Herrenschmidt
2019-07-16 5:59 ` Christoph Hellwig
2019-07-16 5:59 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716120547.GA2388@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.