From: Peter Zijlstra <peterz@infradead.org>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>, Borislav Petkov <bp@suse.de>,
syzbot+370a6b0f11867bf13515@syzkaller.appspotmail.com,
Jiri Olsa <jolsa@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 0/2] perf/hw_breakpoint: Fix breakpoint overcommit issue
Date: Tue, 16 Jul 2019 15:50:23 +0200 [thread overview]
Message-ID: <20190716135023.GD3402@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190716134219.GB4000@lenoir>
On Tue, Jul 16, 2019 at 03:42:20PM +0200, Frederic Weisbecker wrote:
> On Mon, Jul 15, 2019 at 02:47:37PM +0200, Peter Zijlstra wrote:
> > On Thu, Jul 11, 2019 at 12:53:05PM +0200, Peter Zijlstra wrote:
> > > > I wish we could use event->ctx->task instead but on pmu::init() there
> > > > is no ctx yet (we could pass the task in parameter though)
> > >
> > > Right, that should be fairly easy.
> > >
> > > > and on event->destroy() it's TASK_TOMBSTONE and retrieving the task at
> > > > that time would be non trivial.
> > >
> > > Well, right, we can maybe make TOMBSTONE be the LSB instead of the whole
> > > word, then we can recover the task pointer... *yuck* though.
> >
> > Something like the attached, completely untested patches.
> >
> > I didn't do the hw_breakpoint bit, because I got lost in that, but this
> > basically provides what you asked for I think.
> >
>
> Thanks they look good! I can take them and work on top if you like.
please do.
prev parent reply other threads:[~2019-07-16 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 13:48 [PATCH 0/2] perf/hw_breakpoint: Fix breakpoint overcommit issue Frederic Weisbecker
2019-07-09 13:48 ` [PATCH 1/2] perf: Allow a pmu to pin context Frederic Weisbecker
2019-07-09 13:48 ` [PATCH 2/2] perf/hw_breakpoints: Pin perf contexts of breakpoints Frederic Weisbecker
2019-07-10 14:04 ` [PATCH 0/2] perf/hw_breakpoint: Fix breakpoint overcommit issue Peter Zijlstra
2019-07-10 15:34 ` Frederic Weisbecker
2019-07-11 10:53 ` Peter Zijlstra
2019-07-15 12:47 ` Peter Zijlstra
2019-07-16 13:42 ` Frederic Weisbecker
2019-07-16 13:50 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716135023.GD3402@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=bp@suse.de \
--cc=dvyukov@google.com \
--cc=frederic@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=syzbot+370a6b0f11867bf13515@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.