From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] keyboard: remove set but not used variables 'sts'
Date: Tue, 16 Jul 2019 18:17:06 +0000 [thread overview]
Message-ID: <20190716181706.GA1140@penguin> (raw)
In-Reply-To: <20190716085423.19443-1-maowenan@huawei.com>
On Tue, Jul 16, 2019 at 04:54:23PM +0800, Mao Wenan wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/input/keyboard/applespi.c: In function applespi_set_bl_level:
> drivers/input/keyboard/applespi.c:902:6: warning: variable sts set but not used [-Wunused-but-set-variable]
>
> Fixes: b426ac0452093d ("Input: add Apple SPI keyboard and trackpad driver")
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied, thank you.
> ---
> drivers/input/keyboard/applespi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c
> index c1a6843..548737e 100644
> --- a/drivers/input/keyboard/applespi.c
> +++ b/drivers/input/keyboard/applespi.c
> @@ -899,7 +899,6 @@ static void applespi_set_bl_level(struct led_classdev *led_cdev,
> struct applespi_data *applespi > container_of(led_cdev, struct applespi_data, backlight_info);
> unsigned long flags;
> - int sts;
>
> spin_lock_irqsave(&applespi->cmd_msg_lock, flags);
>
> @@ -916,7 +915,7 @@ static void applespi_set_bl_level(struct led_classdev *led_cdev,
> KBD_BL_LEVEL_MIN);
> }
>
> - sts = applespi_send_cmd_msg(applespi);
> + applespi_send_cmd_msg(applespi);
>
> spin_unlock_irqrestore(&applespi->cmd_msg_lock, flags);
> }
> --
> 2.7.4
>
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mao Wenan <maowenan@huawei.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] keyboard: remove set but not used variables 'sts'
Date: Tue, 16 Jul 2019 20:17:06 +0200 [thread overview]
Message-ID: <20190716181706.GA1140@penguin> (raw)
In-Reply-To: <20190716085423.19443-1-maowenan@huawei.com>
On Tue, Jul 16, 2019 at 04:54:23PM +0800, Mao Wenan wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/input/keyboard/applespi.c: In function applespi_set_bl_level:
> drivers/input/keyboard/applespi.c:902:6: warning: variable sts set but not used [-Wunused-but-set-variable]
>
> Fixes: b426ac0452093d ("Input: add Apple SPI keyboard and trackpad driver")
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
Applied, thank you.
> ---
> drivers/input/keyboard/applespi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c
> index c1a6843..548737e 100644
> --- a/drivers/input/keyboard/applespi.c
> +++ b/drivers/input/keyboard/applespi.c
> @@ -899,7 +899,6 @@ static void applespi_set_bl_level(struct led_classdev *led_cdev,
> struct applespi_data *applespi =
> container_of(led_cdev, struct applespi_data, backlight_info);
> unsigned long flags;
> - int sts;
>
> spin_lock_irqsave(&applespi->cmd_msg_lock, flags);
>
> @@ -916,7 +915,7 @@ static void applespi_set_bl_level(struct led_classdev *led_cdev,
> KBD_BL_LEVEL_MIN);
> }
>
> - sts = applespi_send_cmd_msg(applespi);
> + applespi_send_cmd_msg(applespi);
>
> spin_unlock_irqrestore(&applespi->cmd_msg_lock, flags);
> }
> --
> 2.7.4
>
--
Dmitry
next prev parent reply other threads:[~2019-07-16 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 8:54 [PATCH -next] keyboard: remove set but not used variables 'sts' Mao Wenan
2019-07-16 8:54 ` Mao Wenan
2019-07-16 8:54 ` Mao Wenan
2019-07-16 18:17 ` Dmitry Torokhov [this message]
2019-07-16 18:17 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190716181706.GA1140@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maowenan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.