From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Peter Zijlstra <peterz@infradead.org>,
Igor Lubashev <ilubashe@akamai.com>,
linux-kernel@vger.kernel.org, James Morris <jmorris@namei.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] perf: Add capability-related utilities
Date: Wed, 17 Jul 2019 18:05:51 -0300 [thread overview]
Message-ID: <20190717210551.GI3624@kernel.org> (raw)
In-Reply-To: <20190716084643.GA22317@krava>
Em Tue, Jul 16, 2019 at 10:46:43AM +0200, Jiri Olsa escreveu:
> On Tue, Jul 02, 2019 at 08:10:03PM -0400, Igor Lubashev wrote:
> > Add utilities to help checking capabilities of the running process.
> > Make perf link with libcap.
> >
> > Signed-off-by: Igor Lubashev <ilubashe@akamai.com>
> > ---
> > tools/perf/Makefile.config | 2 +-
> > tools/perf/util/Build | 1 +
> > tools/perf/util/cap.c | 24 ++++++++++++++++++++++++
> > tools/perf/util/cap.h | 10 ++++++++++
> > tools/perf/util/event.h | 1 +
> > tools/perf/util/python-ext-sources | 1 +
> > tools/perf/util/util.c | 9 +++++++++
> > 7 files changed, 47 insertions(+), 1 deletion(-)
> > create mode 100644 tools/perf/util/cap.c
> > create mode 100644 tools/perf/util/cap.h
> >
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index 85fbcd265351..21470a50ed39 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -259,7 +259,7 @@ CXXFLAGS += -Wno-strict-aliasing
> > # adding assembler files missing the .GNU-stack linker note.
> > LDFLAGS += -Wl,-z,noexecstack
> >
> > -EXTLIBS = -lpthread -lrt -lm -ldl
> > +EXTLIBS = -lpthread -lrt -lm -ldl -lcap
>
> I wonder we should detect libcap or it's everywhere.. Arnaldo's compile test suite might tell
I'll add this tentatively and try to build it in my test suite.
- Arnaldo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Igor Lubashev <ilubashe@akamai.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-arm-kernel@lists.infradead.org,
James Morris <jmorris@namei.org>
Subject: Re: [PATCH 1/3] perf: Add capability-related utilities
Date: Wed, 17 Jul 2019 18:05:51 -0300 [thread overview]
Message-ID: <20190717210551.GI3624@kernel.org> (raw)
In-Reply-To: <20190716084643.GA22317@krava>
Em Tue, Jul 16, 2019 at 10:46:43AM +0200, Jiri Olsa escreveu:
> On Tue, Jul 02, 2019 at 08:10:03PM -0400, Igor Lubashev wrote:
> > Add utilities to help checking capabilities of the running process.
> > Make perf link with libcap.
> >
> > Signed-off-by: Igor Lubashev <ilubashe@akamai.com>
> > ---
> > tools/perf/Makefile.config | 2 +-
> > tools/perf/util/Build | 1 +
> > tools/perf/util/cap.c | 24 ++++++++++++++++++++++++
> > tools/perf/util/cap.h | 10 ++++++++++
> > tools/perf/util/event.h | 1 +
> > tools/perf/util/python-ext-sources | 1 +
> > tools/perf/util/util.c | 9 +++++++++
> > 7 files changed, 47 insertions(+), 1 deletion(-)
> > create mode 100644 tools/perf/util/cap.c
> > create mode 100644 tools/perf/util/cap.h
> >
> > diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
> > index 85fbcd265351..21470a50ed39 100644
> > --- a/tools/perf/Makefile.config
> > +++ b/tools/perf/Makefile.config
> > @@ -259,7 +259,7 @@ CXXFLAGS += -Wno-strict-aliasing
> > # adding assembler files missing the .GNU-stack linker note.
> > LDFLAGS += -Wl,-z,noexecstack
> >
> > -EXTLIBS = -lpthread -lrt -lm -ldl
> > +EXTLIBS = -lpthread -lrt -lm -ldl -lcap
>
> I wonder we should detect libcap or it's everywhere.. Arnaldo's compile test suite might tell
I'll add this tentatively and try to build it in my test suite.
- Arnaldo
next prev parent reply other threads:[~2019-07-17 21:06 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 0:10 [PATCH 0/3] perf: Use capabilities instead of uid and euid Igor Lubashev
2019-07-03 0:10 ` Igor Lubashev
2019-07-03 0:10 ` [PATCH 1/3] perf: Add capability-related utilities Igor Lubashev
2019-07-03 0:10 ` Igor Lubashev
2019-07-16 8:46 ` Jiri Olsa
2019-07-16 8:46 ` Jiri Olsa
2019-07-17 21:05 ` Arnaldo Carvalho de Melo [this message]
2019-07-17 21:05 ` Arnaldo Carvalho de Melo
2019-07-17 23:46 ` Arnaldo Carvalho de Melo
2019-07-17 23:46 ` Arnaldo Carvalho de Melo
2019-07-17 23:48 ` Arnaldo Carvalho de Melo
2019-07-17 23:48 ` Arnaldo Carvalho de Melo
2019-07-18 21:00 ` Lubashev, Igor
2019-07-18 21:00 ` Lubashev, Igor
2019-08-07 3:58 ` Lubashev, Igor
2019-08-07 3:58 ` Lubashev, Igor
2019-07-03 0:10 ` [PATCH 2/3] perf: Use CAP_SYS_ADMIN with perf_event_paranoid checks Igor Lubashev
2019-07-03 0:10 ` Igor Lubashev
2019-07-16 8:47 ` Jiri Olsa
2019-07-16 8:47 ` Jiri Olsa
2019-07-16 17:01 ` Lubashev, Igor
2019-07-16 17:01 ` Lubashev, Igor
2019-07-17 7:10 ` Jiri Olsa
2019-07-17 7:10 ` Jiri Olsa
2019-07-17 18:33 ` Lubashev, Igor
2019-07-17 18:33 ` Lubashev, Igor
2019-07-03 0:10 ` [PATCH 3/3] perf: Use CAP_SYSLOG with kptr_restrict checks Igor Lubashev
2019-07-03 0:10 ` Igor Lubashev
2019-07-16 10:51 ` [PATCH 0/3] perf: Use capabilities instead of uid and euid Alexey Budankov
2019-07-16 10:51 ` Alexey Budankov
2019-07-17 18:15 ` [PATCH 4/3] perf: Use CAP_SYS_ADMIN instead of euid==0 with ftrace Igor Lubashev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190717210551.GI3624@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=ilubashe@akamai.com \
--cc=jmorris@namei.org \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.