From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christoph Hellwig <hch@infradead.org>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>,
Andreas Gruenbacher <agruenba@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n
Date: Thu, 18 Jul 2019 14:57:03 +0200 [thread overview]
Message-ID: <20190718125703.GA28332@lst.de> (raw)
In-Reply-To: <20190718125509.775525-1-arnd@arndb.de>
On Thu, Jul 18, 2019 at 02:55:01PM +0200, Arnd Bergmann wrote:
> When CONFIG_BLOCK is disabled, SECTOR_SHIFT is unknown:
>
> In file included from <built-in>:3:
> include/linux/iomap.h:76:48: error: use of undeclared identifier 'SECTOR_SHIFT'
> return (iomap->addr + pos - iomap->offset) >> SECTOR_SHIFT;
>
> Since there are no callers in this case, just hide the function in
> the same ifdef.
>
> Fixes: db074436f421 ("iomap: move the direct IO code into a separate file")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Can we just not include iomap.c when CONFIG_BLOCK is not set?
Which file do you see this with?
next prev parent reply other threads:[~2019-07-18 12:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 12:55 [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n Arnd Bergmann
2019-07-18 12:57 ` Christoph Hellwig [this message]
2019-07-18 13:03 ` Arnd Bergmann
2019-07-18 13:08 ` Christoph Hellwig
2019-07-18 14:25 ` Darrick J. Wong
2019-07-19 2:19 ` Masahiro Yamada
2019-07-19 2:24 ` Randy Dunlap
2019-07-19 2:32 ` Masahiro Yamada
2019-07-19 5:58 ` Christoph Hellwig
2019-07-19 6:16 ` Masahiro Yamada
2019-07-19 6:19 ` Christoph Hellwig
2019-07-18 14:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718125703.GA28332@lst.de \
--to=hch@lst.de \
--cc=agruenba@redhat.com \
--cc=arnd@arndb.de \
--cc=darrick.wong@oracle.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.