From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Arnd Bergmann <arnd@arndb.de>,
Christoph Hellwig <hch@infradead.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
Andreas Gruenbacher <agruenba@redhat.com>,
Hannes Reinecke <hare@suse.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n
Date: Thu, 18 Jul 2019 07:25:25 -0700 [thread overview]
Message-ID: <20190718142525.GE7116@magnolia> (raw)
In-Reply-To: <20190718130835.GA28520@lst.de>
On Thu, Jul 18, 2019 at 03:08:35PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 18, 2019 at 03:03:15PM +0200, Arnd Bergmann wrote:
> > The inclusion comes from the recently added header check in commit
> > c93a0368aaa2 ("kbuild: do not create wrappers for header-test-y").
> >
> > This just tries to include every header by itself to see if there are build
> > failures from missing indirect includes. We probably don't want to
> > add an exception for iomap.h there.
>
> I very much disagree with that check. We don't need to make every
> header compilable with a setup where it should not be included.
Seconded, unless there's some scenario where someone needs iomap when
CONFIG_BLOCK=n (???)
--D
> That being said if you feel this is worth fixing I'd rather define
> SECTOR_SIZE/SECTOR_SHIFT unconditionally.
next prev parent reply other threads:[~2019-07-18 14:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-18 12:55 [PATCH] iomap: hide iomap_sector with CONFIG_BLOCK=n Arnd Bergmann
2019-07-18 12:57 ` Christoph Hellwig
2019-07-18 13:03 ` Arnd Bergmann
2019-07-18 13:08 ` Christoph Hellwig
2019-07-18 14:25 ` Darrick J. Wong [this message]
2019-07-19 2:19 ` Masahiro Yamada
2019-07-19 2:24 ` Randy Dunlap
2019-07-19 2:32 ` Masahiro Yamada
2019-07-19 5:58 ` Christoph Hellwig
2019-07-19 6:16 ` Masahiro Yamada
2019-07-19 6:19 ` Christoph Hellwig
2019-07-18 14:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190718142525.GE7116@magnolia \
--to=darrick.wong@oracle.com \
--cc=agruenba@redhat.com \
--cc=arnd@arndb.de \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=jani.nikula@intel.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.