* [PATCH] ext4: remove unnecessary error check [not found] <cover.1562138716.git.shisiyuan@xiaomi.com> @ 2019-07-03 8:16 ` Shi Siyuan 2019-07-18 15:17 ` Theodore Y. Ts'o 0 siblings, 1 reply; 2+ messages in thread From: Shi Siyuan @ 2019-07-03 8:16 UTC (permalink / raw) To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, shisiyuan From: shisiyuan <shisiyuan@xiaomi.com> Remove unnecessary error check in ext4_file_write_iter(), because this check will be done in upcoming later function -- ext4_write_checks() -> generic_write_checks() Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e Signed-off-by: shisiyuan <shisiyuan@xiaomi.com> --- fs/ext4/file.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/ext4/file.c b/fs/ext4/file.c index 5cb9aa3..9e4c39e 100644 --- a/fs/ext4/file.c +++ b/fs/ext4/file.c @@ -224,8 +224,6 @@ ext4_file_write_iter(struct kiocb *iocb, struct iov_iter *from) if (IS_DAX(inode)) return ext4_dax_write_iter(iocb, from); #endif - if (!o_direct && (iocb->ki_flags & IOCB_NOWAIT)) - return -EOPNOTSUPP; if (!inode_trylock(inode)) { if (iocb->ki_flags & IOCB_NOWAIT) -- 2.7.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: remove unnecessary error check 2019-07-03 8:16 ` [PATCH] ext4: remove unnecessary error check Shi Siyuan @ 2019-07-18 15:17 ` Theodore Y. Ts'o 0 siblings, 0 replies; 2+ messages in thread From: Theodore Y. Ts'o @ 2019-07-18 15:17 UTC (permalink / raw) To: Shi Siyuan; +Cc: adilger.kernel, linux-ext4, linux-kernel, shisiyuan On Wed, Jul 03, 2019 at 04:16:54PM +0800, Shi Siyuan wrote: > From: shisiyuan <shisiyuan@xiaomi.com> > > Remove unnecessary error check in ext4_file_write_iter(), > because this check will be done in upcoming later function -- > ext4_write_checks() -> generic_write_checks() > > Change-Id: I7b0ab27f693a50765c15b5eaa3f4e7c38f42e01e > Signed-off-by: shisiyuan <shisiyuan@xiaomi.com> Thanks, applied. - Ted ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 15:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1562138716.git.shisiyuan@xiaomi.com>
2019-07-03 8:16 ` [PATCH] ext4: remove unnecessary error check Shi Siyuan
2019-07-18 15:17 ` Theodore Y. Ts'o
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.