[PATCH] drm/amdkfd: Fix missing break in switch statement

[PATCH] drm/amdkfd: Fix missing break in switch statement

[Gustavo A. R. Silva]

Add missing break statement in order to prevent the code from falling
through to case CHIP_NAVI10.

This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.

Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
Cc: stable@vger.kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
index 792371442195..4e3fc284f6ac 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
@@ -668,6 +668,7 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
 	case CHIP_RAVEN:
 		pcache_info = raven_cache_info;
 		num_of_cache_types = ARRAY_SIZE(raven_cache_info);
+		break;
 	case CHIP_NAVI10:
 		pcache_info = navi10_cache_info;
 		num_of_cache_types = ARRAY_SIZE(navi10_cache_info);
-- 
2.22.0

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

[Alex Deucher]

On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
> Add missing break statement in order to prevent the code from falling
> through to case CHIP_NAVI10.
>
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index 792371442195..4e3fc284f6ac 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -668,6 +668,7 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
>         case CHIP_RAVEN:
>                 pcache_info = raven_cache_info;
>                 num_of_cache_types = ARRAY_SIZE(raven_cache_info);
> +               break;
>         case CHIP_NAVI10:
>                 pcache_info = navi10_cache_info;
>                 num_of_cache_types = ARRAY_SIZE(navi10_cache_info);
> --
> 2.22.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

[Gustavo A. R. Silva]

On 7/22/19 2:10 PM, Alex Deucher wrote:
> On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva
> <gustavo@embeddedor.com> wrote:
>>
>> Add missing break statement in order to prevent the code from falling
>> through to case CHIP_NAVI10.
>>
>> This bug was found thanks to the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> 
> Applied.  Thanks!
> 

By the way, Alex, I'm planning to add these fixes to my tree. I want
to send a pull-request to Linus for v5.3-rc2 this afternoon. We want
to have the -Wimplicit-fallthrough option globally enabled in v5.3,
and these are some of the last fall-through warnings remaining in
the kernel.

Can I have your Ack or Signed-off-by for all these drm patches?

Thanks!
--
Gustavo

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

[Alex Deucher]

On Mon, Jul 22, 2019 at 3:19 PM Gustavo A. R. Silva
<gustavo@embeddedor.com> wrote:
>
>
>
> On 7/22/19 2:10 PM, Alex Deucher wrote:
> > On Sun, Jul 21, 2019 at 6:12 PM Gustavo A. R. Silva
> > <gustavo@embeddedor.com> wrote:
> >>
> >> Add missing break statement in order to prevent the code from falling
> >> through to case CHIP_NAVI10.
> >>
> >> This bug was found thanks to the ongoing efforts to enable
> >> -Wimplicit-fallthrough.
> >>
> >> Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)")
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> >
> > Applied.  Thanks!
> >
>
> By the way, Alex, I'm planning to add these fixes to my tree. I want
> to send a pull-request to Linus for v5.3-rc2 this afternoon. We want
> to have the -Wimplicit-fallthrough option globally enabled in v5.3,
> and these are some of the last fall-through warnings remaining in
> the kernel.
>
> Can I have your Ack or Signed-off-by for all these drm patches?

I didn't realize you were sending these yourself. I was going to
include them in my upcoming -fixes pull.  Feel free to add my RB to
all three.

Alex

Re: [PATCH] drm/amdkfd: Fix missing break in switch statement

[Gustavo A. R. Silva]

On 7/22/19 2:45 PM, Alex Deucher wrote:

>>
>> By the way, Alex, I'm planning to add these fixes to my tree. I want
>> to send a pull-request to Linus for v5.3-rc2 this afternoon. We want
>> to have the -Wimplicit-fallthrough option globally enabled in v5.3,
>> and these are some of the last fall-through warnings remaining in
>> the kernel.
>>
>> Can I have your Ack or Signed-off-by for all these drm patches?
> 
> I didn't realize you were sending these yourself. I was going to
> include them in my upcoming -fixes pull.  Feel free to add my RB to
> all three.
> 

Awesome! :)

Thanks
--
Gustavo