From: Shawn Guo <shawnguo@kernel.org>
To: fugang.duan@nxp.com
Cc: devicetree@vger.kernel.org, daniel.baluta@gmail.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock
Date: Mon, 22 Jul 2019 14:46:50 +0800 [thread overview]
Message-ID: <20190722064649.GA3738@dragon> (raw)
In-Reply-To: <20190704100443.10957-1-fugang.duan@nxp.com>
On Thu, Jul 04, 2019 at 06:04:43PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Add imx8qxp lpuart baud clock.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 05fa0b7..4402b2e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -30,6 +30,9 @@
> mmc2 = &usdhc3;
> mu1 = &lsio_mu1;
> serial0 = &adma_lpuart0;
> + serial1 = &adma_lpuart1;
> + serial2 = &adma_lpuart2;
> + serial3 = &adma_lpuart3;
This is not about adding baud clock, right? Please either mention the
change in the commit log, or have it as a separate patch.
Shawn
> };
>
> cpus {
> @@ -209,8 +212,9 @@
> reg = <0x5a060000 0x1000>;
> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_0>;
> status = "disabled";
> };
> @@ -220,8 +224,9 @@
> reg = <0x5a070000 0x1000>;
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_1>;
> status = "disabled";
> };
> @@ -231,8 +236,9 @@
> reg = <0x5a080000 0x1000>;
> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_2>;
> status = "disabled";
> };
> @@ -242,8 +248,9 @@
> reg = <0x5a090000 0x1000>;
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_3>;
> status = "disabled";
> };
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: fugang.duan@nxp.com
Cc: devicetree@vger.kernel.org, daniel.baluta@gmail.com,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock
Date: Mon, 22 Jul 2019 14:46:50 +0800 [thread overview]
Message-ID: <20190722064649.GA3738@dragon> (raw)
In-Reply-To: <20190704100443.10957-1-fugang.duan@nxp.com>
On Thu, Jul 04, 2019 at 06:04:43PM +0800, fugang.duan@nxp.com wrote:
> From: Fugang Duan <fugang.duan@nxp.com>
>
> Add imx8qxp lpuart baud clock.
>
> Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 23 +++++++++++++++--------
> 1 file changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 05fa0b7..4402b2e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -30,6 +30,9 @@
> mmc2 = &usdhc3;
> mu1 = &lsio_mu1;
> serial0 = &adma_lpuart0;
> + serial1 = &adma_lpuart1;
> + serial2 = &adma_lpuart2;
> + serial3 = &adma_lpuart3;
This is not about adding baud clock, right? Please either mention the
change in the commit log, or have it as a separate patch.
Shawn
> };
>
> cpus {
> @@ -209,8 +212,9 @@
> reg = <0x5a060000 0x1000>;
> interrupts = <GIC_SPI 225 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART0_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART0_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_0>;
> status = "disabled";
> };
> @@ -220,8 +224,9 @@
> reg = <0x5a070000 0x1000>;
> interrupts = <GIC_SPI 226 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART1_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART1_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_1>;
> status = "disabled";
> };
> @@ -231,8 +236,9 @@
> reg = <0x5a080000 0x1000>;
> interrupts = <GIC_SPI 227 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART2_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART2_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_2>;
> status = "disabled";
> };
> @@ -242,8 +248,9 @@
> reg = <0x5a090000 0x1000>;
> interrupts = <GIC_SPI 228 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-parent = <&gic>;
> - clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> - clock-names = "ipg";
> + clocks = <&adma_lpcg IMX_ADMA_LPCG_UART3_IPG_CLK>,
> + <&adma_lpcg IMX_ADMA_LPCG_UART3_BAUD_CLK>;
> + clock-names = "ipg", "baud";
> power-domains = <&pd IMX_SC_R_UART_3>;
> status = "disabled";
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-07-22 6:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-04 10:04 [PATCH arm64/dts 1/1] arm64: dts: imx8qxp: add lpuart baud clock fugang.duan
2019-07-04 10:04 ` fugang.duan
2019-07-22 6:46 ` Shawn Guo [this message]
2019-07-22 6:46 ` Shawn Guo
2019-07-22 6:52 ` [EXT] " Andy Duan
2019-07-22 6:52 ` Andy Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722064649.GA3738@dragon \
--to=shawnguo@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.