All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: linux-kselftest@vger.kernel.org, skhan@linuxfoundation.org,
	Vasily Gorbik <gor@linux.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>
Subject: Re: "make" vs "$(MAKE)" in tools/testing/selftests/Makefile
Date: Mon, 22 Jul 2019 10:19:59 -0700	[thread overview]
Message-ID: <201907221019.DC708E775@keescook> (raw)
In-Reply-To: <AE9B539F-DEBE-4CE2-91DB-9EA2DA2A9DEA@linux.ibm.com>

On Thu, Jul 18, 2019 at 05:48:30PM +0200, Ilya Leoshkevich wrote:
> Hello,
> 
> Is there a reason why kselftest Makefile uses plain "make" instead of
> "$(MAKE)"?
> 
> Because of this, "make kselftest TARGETS=bpf -j12" ends up building all
> bpf tests sequentially, since the top make's jobserver is not shared
> with its children. Replacing "make" with "$(MAKE)" helps, but since
> other Makefiles use "$(MAKE)", it looks as if this has been done
> intentionally.

I suspect it's just an oversight. Can you send a patch to fix this?

-- 
Kees Cook

  reply	other threads:[~2019-07-22 17:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 15:48 "make" vs "$(MAKE)" in tools/testing/selftests/Makefile Ilya Leoshkevich
2019-07-22 17:19 ` Kees Cook [this message]
2019-07-22 17:23   ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201907221019.DC708E775@keescook \
    --to=keescook@chromium.org \
    --cc=gor@linux.ibm.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.