* "make" vs "$(MAKE)" in tools/testing/selftests/Makefile
@ 2019-07-18 15:48 Ilya Leoshkevich
2019-07-22 17:19 ` Kees Cook
0 siblings, 1 reply; 3+ messages in thread
From: Ilya Leoshkevich @ 2019-07-18 15:48 UTC (permalink / raw)
To: linux-kselftest, skhan, keescook; +Cc: Vasily Gorbik, Heiko Carstens
Hello,
Is there a reason why kselftest Makefile uses plain "make" instead of
"$(MAKE)"?
Because of this, "make kselftest TARGETS=bpf -j12" ends up building all
bpf tests sequentially, since the top make's jobserver is not shared
with its children. Replacing "make" with "$(MAKE)" helps, but since
other Makefiles use "$(MAKE)", it looks as if this has been done
intentionally.
Best regards,
Ilya
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "make" vs "$(MAKE)" in tools/testing/selftests/Makefile
2019-07-18 15:48 "make" vs "$(MAKE)" in tools/testing/selftests/Makefile Ilya Leoshkevich
@ 2019-07-22 17:19 ` Kees Cook
2019-07-22 17:23 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Kees Cook @ 2019-07-22 17:19 UTC (permalink / raw)
To: Ilya Leoshkevich; +Cc: linux-kselftest, skhan, Vasily Gorbik, Heiko Carstens
On Thu, Jul 18, 2019 at 05:48:30PM +0200, Ilya Leoshkevich wrote:
> Hello,
>
> Is there a reason why kselftest Makefile uses plain "make" instead of
> "$(MAKE)"?
>
> Because of this, "make kselftest TARGETS=bpf -j12" ends up building all
> bpf tests sequentially, since the top make's jobserver is not shared
> with its children. Replacing "make" with "$(MAKE)" helps, but since
> other Makefiles use "$(MAKE)", it looks as if this has been done
> intentionally.
I suspect it's just an oversight. Can you send a patch to fix this?
--
Kees Cook
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: "make" vs "$(MAKE)" in tools/testing/selftests/Makefile
2019-07-22 17:19 ` Kees Cook
@ 2019-07-22 17:23 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2019-07-22 17:23 UTC (permalink / raw)
To: Kees Cook, Ilya Leoshkevich
Cc: linux-kselftest, Vasily Gorbik, Heiko Carstens,
sk >> Shuah Khan
On 7/22/19 11:19 AM, Kees Cook wrote:
> On Thu, Jul 18, 2019 at 05:48:30PM +0200, Ilya Leoshkevich wrote:
>> Hello,
>>
>> Is there a reason why kselftest Makefile uses plain "make" instead of
>> "$(MAKE)"?
>>
>> Because of this, "make kselftest TARGETS=bpf -j12" ends up building all
>> bpf tests sequentially, since the top make's jobserver is not shared
>> with its children. Replacing "make" with "$(MAKE)" helps, but since
>> other Makefiles use "$(MAKE)", it looks as if this has been done
>> intentionally.
>
> I suspect it's just an oversight. Can you send a patch to fix this?
>
Sorry for late reply. I have been traveling.
Please make the change and send the patch. Also make sure all the
use-cases work?
i.e make kselftest
make -c <individual tests build>
make -C <selftest build - all tests invoking selftest Makefile)
I recall there are some issues using $(MAKE) when I added the
support a while back. I don't recall what it was.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-22 17:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-18 15:48 "make" vs "$(MAKE)" in tools/testing/selftests/Makefile Ilya Leoshkevich
2019-07-22 17:19 ` Kees Cook
2019-07-22 17:23 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.