From: tytso@mit.edu (Theodore Y. Ts'o)
Subject: [PATCH v3 23/24] erofs: introduce cached decompression
Date: Mon, 22 Jul 2019 09:25:13 -0400 [thread overview]
Message-ID: <20190722132513.GA5172@mit.edu> (raw)
In-Reply-To: <41f1659a-0d16-4316-34fc-335b7d142d5c@aol.com>
On Mon, Jul 22, 2019@06:58:59PM +0800, Gao Xiang wrote:
> > The number of individual Kconfig options is quite high, are you sure you
> > need them to be split like that?
>
> You mean the above? these are 3 cache strategies, which impact the
> runtime memory consumption and performance. I tend to leave the above
> as it-is...
Unless cache strategies involve a huge amount of kernel code, I'd
recommend always compiling all of the cache strategies, and then have
a way to change the cache strategy via a mount option (and possibly
remount, although that can get tricky if there is already cached
information). You could also specify a default in the erofs
superblock, you think that would be useful.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Gao Xiang <hsiangkao@aol.com>
Cc: dsterba@suse.cz, Gao Xiang <gaoxiang25@huawei.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, devel@driverdev.osuosl.org,
LKML <linux-kernel@vger.kernel.org>,
linux-erofs@lists.ozlabs.org, Chao Yu <yuchao0@huawei.com>,
Miao Xie <miaoxie@huawei.com>,
Li Guifu <bluce.liguifu@huawei.com>,
Fang Wei <fangwei1@huawei.com>
Subject: Re: [PATCH v3 23/24] erofs: introduce cached decompression
Date: Mon, 22 Jul 2019 09:25:13 -0400 [thread overview]
Message-ID: <20190722132513.GA5172@mit.edu> (raw)
In-Reply-To: <41f1659a-0d16-4316-34fc-335b7d142d5c@aol.com>
On Mon, Jul 22, 2019 at 06:58:59PM +0800, Gao Xiang wrote:
> > The number of individual Kconfig options is quite high, are you sure you
> > need them to be split like that?
>
> You mean the above? these are 3 cache strategies, which impact the
> runtime memory consumption and performance. I tend to leave the above
> as it-is...
Unless cache strategies involve a huge amount of kernel code, I'd
recommend always compiling all of the cache strategies, and then have
a way to change the cache strategy via a mount option (and possibly
remount, although that can get tricky if there is already cached
information). You could also specify a default in the erofs
superblock, you think that would be useful.
- Ted
next prev parent reply other threads:[~2019-07-22 13:25 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 2:50 [PATCH v3 00/24] erofs: promote erofs from staging Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 01/24] erofs: add on-disk layout Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 3:26 ` Stephen Rothwell
2019-07-22 3:26 ` Stephen Rothwell
2019-07-22 3:29 ` Gao Xiang
2019-07-22 3:29 ` Gao Xiang
2019-07-22 5:05 ` Greg Kroah-Hartman
2019-07-22 5:05 ` Greg Kroah-Hartman
2019-07-22 5:24 ` Gao Xiang
2019-07-22 5:24 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 02/24] erofs: add erofs in-memory stuffs Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 03/24] erofs: add super block operations Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 04/24] erofs: add raw address_space operations Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 05/24] erofs: add inode operations Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 06/24] erofs: support special inode Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 07/24] erofs: add directory operations Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 08/24] erofs: add namei functions Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 09/24] erofs: support tracepoint Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 10/24] erofs: update Kconfig and Makefile Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 11/24] erofs: introduce xattr & posixacl support Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 12/24] erofs: introduce tagged pointer Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 4:39 ` Amir Goldstein
2019-07-22 4:39 ` Amir Goldstein
2019-07-22 5:01 ` Gao Xiang
2019-07-22 5:01 ` Gao Xiang
2019-07-22 6:16 ` Amir Goldstein
2019-07-22 6:16 ` Amir Goldstein
2019-07-22 6:31 ` Gao Xiang
2019-07-22 6:31 ` Gao Xiang
2019-07-22 14:40 ` Steven Rostedt
2019-07-22 14:40 ` Steven Rostedt
2019-07-22 15:33 ` Gao Xiang
2019-07-22 15:33 ` Gao Xiang
2019-07-22 16:35 ` Steven Rostedt
2019-07-22 16:35 ` Steven Rostedt
2019-07-22 16:52 ` Gao Xiang
2019-07-22 16:52 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 13/24] erofs: add compression indexes support Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 14/24] erofs: introduce superblock registration Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 15/24] erofs: introduce erofs shrinker Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 16/24] erofs: introduce workstation for decompression Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 17/24] erofs: introduce per-CPU buffers implementation Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 18/24] erofs: introduce pagevec for decompression subsystem Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 19/24] erofs: add erofs_allocpage() Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 20/24] erofs: introduce generic decompression backend Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 21/24] erofs: introduce LZ4 decompression inplace Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 22/24] erofs: introduce the decompression frontend Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 23/24] erofs: introduce cached decompression Gao Xiang
2019-07-22 2:50 ` Gao Xiang
2019-07-22 10:18 ` David Sterba
2019-07-22 10:18 ` David Sterba
2019-07-22 10:58 ` Gao Xiang
2019-07-22 10:58 ` Gao Xiang
2019-07-22 13:25 ` Theodore Y. Ts'o [this message]
2019-07-22 13:25 ` Theodore Y. Ts'o
2019-07-22 14:16 ` Gao Xiang
2019-07-22 14:16 ` Gao Xiang
2019-07-22 15:12 ` Theodore Y. Ts'o
2019-07-22 15:12 ` Theodore Y. Ts'o
2019-07-22 16:27 ` Gao Xiang
2019-07-22 16:27 ` Gao Xiang
2019-07-23 12:31 ` David Sterba
2019-07-23 12:31 ` David Sterba
2019-07-23 13:30 ` Gao Xiang
2019-07-23 13:30 ` Gao Xiang
2019-07-22 2:50 ` [PATCH v3 24/24] erofs: add document Gao Xiang
2019-07-22 2:50 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722132513.GA5172@mit.edu \
--to=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.