From: stillcompiling@gmail.com
To: Joe Perches <joe@perches.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Cc: Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH v2 3/3] HID: core: only warn once of oversize hid report
Date: Mon, 22 Jul 2019 15:26:13 -0600 [thread overview]
Message-ID: <20190722212613.24906-3-stillcompiling@gmail.com> (raw)
In-Reply-To: <20190722212613.24906-1-stillcompiling@gmail.com>
From: Joshua Clayton <stillcompiling@gmail.com>
On HP spectre x360 convertible the message:
hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2)
is continually printed many times per second, crowding out all else
Protect dmesg by printing the warning only one time.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/hid/hid-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 210b81a56e1a..0cb53dddf341 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device *hid, u8 *report,
unsigned offset, unsigned n)
{
if (n > 32) {
- hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n",
- n, current->comm);
+ hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n",
+ __func__ ,n , current->comm);
n = 32;
}
--
2.21.0
WARNING: multiple messages have this Message-ID (diff)
From: stillcompiling@gmail.com
To: Joe Perches <joe@perches.com>, Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org (open list:HID CORE LAYER),
linux-kernel@vger.kernel.org (open list)
Cc: Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH v2 3/3] HID: core: only warn once of oversize hid report
Date: Mon, 22 Jul 2019 15:26:13 -0600 [thread overview]
Message-ID: <20190722212613.24906-3-stillcompiling@gmail.com> (raw)
In-Reply-To: <20190722212613.24906-1-stillcompiling@gmail.com>
From: Joshua Clayton <stillcompiling@gmail.com>
On HP spectre x360 convertible the message:
hid-sensor-hub 001F:8087:0AC2.0002: hid_field_extract() called with n (192) > 32! (kworker/1:2)
is continually printed many times per second, crowding out all else
Protect dmesg by printing the warning only one time.
Signed-off-by: Joshua Clayton <stillcompiling@gmail.com>
---
drivers/hid/hid-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 210b81a56e1a..0cb53dddf341 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -1311,8 +1311,8 @@ u32 hid_field_extract(const struct hid_device *hid, u8 *report,
unsigned offset, unsigned n)
{
if (n > 32) {
- hid_warn(hid, "hid_field_extract() called with n (%d) > 32! (%s)\n",
- n, current->comm);
+ hid_warn_once(hid, "%s() called with n (%d) > 32! (%s)\n",
+ __func__ ,n , current->comm);
n = 32;
}
--
2.21.0
next prev parent reply other threads:[~2019-07-22 21:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 16:36 [PATCH 1/2] HID: core: Add hid printk_once macros stillcompiling
2019-07-22 16:36 ` stillcompiling
2019-07-22 16:36 ` [PATCH 2/2] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 16:36 ` stillcompiling
2019-07-22 17:23 ` Joe Perches
2019-07-22 18:16 ` Joshua Clayton
2019-07-22 18:16 ` Joshua Clayton
2019-07-22 21:26 ` [PATCH v2 1/3] HID: core: reformat and reduce hid_printk macros stillcompiling
2019-07-22 21:26 ` stillcompiling
2019-07-22 21:26 ` [PATCH v2 2/3] HID: core: Add printk_once variants to hid_warn() etc stillcompiling
2019-07-22 21:26 ` stillcompiling
2019-07-22 21:26 ` stillcompiling [this message]
2019-07-22 21:26 ` [PATCH v2 3/3] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 21:30 ` Joe Perches
2019-07-22 21:43 ` Joshua Clayton
2019-07-22 21:48 ` [PATCH v3 1/3] HID: core: reformat and reduce hid_printk macros stillcompiling
2019-07-22 21:48 ` stillcompiling
2019-07-22 21:48 ` [PATCH v3 2/3] HID: core: Add printk_once variants to hid_warn() etc stillcompiling
2019-07-22 21:48 ` stillcompiling
2019-07-22 21:48 ` [PATCH v3 3/3] HID: core: only warn once of oversize hid report stillcompiling
2019-07-22 21:48 ` stillcompiling
2019-07-22 17:11 ` [PATCH 1/2] HID: core: Add hid printk_once macros Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190722212613.24906-3-stillcompiling@gmail.com \
--to=stillcompiling@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=joe@perches.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.