All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Codrin.Ciubotariu@microchip.com, Ludovic.Desroches@microchip.com,
	Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
Date: Mon, 22 Jul 2019 14:31:55 -0700	[thread overview]
Message-ID: <20190722213156.8829E21900@mail.kernel.org> (raw)
In-Reply-To: <af07c26e-cef3-f0ff-48ff-68f99ccf4de9@microchip.com>

Quoting Nicolas.Ferre@microchip.com (2019-07-03 08:05:24)
> On 25/06/2019 at 11:10, Codrin Ciubotariu wrote:
> > In clk_generated_determine_rate(), if the divisor is greater than
> > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> > If clk_generated_set_rate() will be called later with this wrong
> > rate, it will return -EINVAL, so the generated clock won't change
> > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
> > 
> > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> > ---
> > 
> > - The email-server was converting my patches to base64, so I resend it
> >    using another server;
> > - Added acked-bys from Nicolas and Ludovic;
> 
> Stephen,
> 
> I don't see this patch in linux-next and we're already late in the 
> development cycle: aka ping...
> 

Sorry. I dropped this one. Will pick it up into fixes.



WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Codrin.Ciubotariu@microchip.com, Ludovic.Desroches@microchip.com,
	Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1
Date: Mon, 22 Jul 2019 14:31:55 -0700	[thread overview]
Message-ID: <20190722213156.8829E21900@mail.kernel.org> (raw)
In-Reply-To: <af07c26e-cef3-f0ff-48ff-68f99ccf4de9@microchip.com>

Quoting Nicolas.Ferre@microchip.com (2019-07-03 08:05:24)
> On 25/06/2019 at 11:10, Codrin Ciubotariu wrote:
> > In clk_generated_determine_rate(), if the divisor is greater than
> > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned.
> > If clk_generated_set_rate() will be called later with this wrong
> > rate, it will return -EINVAL, so the generated clock won't change
> > its value. Do no let the divisor be greater than GENERATED_MAX_DIV + 1.
> > 
> > Fixes: 8c7aa6328947 ("clk: at91: clk-generated: remove useless divisor loop")
> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> > Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
> > Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
> > ---
> > 
> > - The email-server was converting my patches to base64, so I resend it
> >    using another server;
> > - Added acked-bys from Nicolas and Ludovic;
> 
> Stephen,
> 
> I don't see this patch in linux-next and we're already late in the 
> development cycle: aka ping...
> 

Sorry. I dropped this one. Will pick it up into fixes.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-22 21:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-25  9:10 [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1 Codrin Ciubotariu
2019-06-25  9:10 ` Codrin Ciubotariu
2019-07-03 15:05 ` Nicolas.Ferre
2019-07-03 15:05   ` Nicolas.Ferre
2019-07-22 21:31   ` Stephen Boyd [this message]
2019-07-22 21:31     ` Stephen Boyd
2019-07-22 21:32 ` Stephen Boyd
2019-07-22 21:32   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190722213156.8829E21900@mail.kernel.org \
    --to=sboyd@kernel.org \
    --cc=Codrin.Ciubotariu@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.