All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>
Cc: devicetree@vger.kernel.org, patchwork-lst@pengutronix.de,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq: fix SAI compatible
Date: Tue, 23 Jul 2019 15:33:43 +0800	[thread overview]
Message-ID: <20190723073342.GG15632@dragon> (raw)
In-Reply-To: <20190717095436.28154-1-l.stach@pengutronix.de>

Add Daniel for comment.

On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote:
> The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
> register layout has changed due to two version registers being added
> at the beginning of the address map. Remove the bogus compatible.
> 
> Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"

The format should be the following.  I can fix it when applying though.

Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node")

Shawn

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 9326bd4150a3..0c533c66b340 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -718,8 +718,7 @@
>  
>  			sai2: sai@308b0000 {
>  				#sound-dai-cells = <0>;
> -				compatible = "fsl,imx8mq-sai",
> -					     "fsl,imx6sx-sai";
> +				compatible = "fsl,imx8mq-sai";
>  				reg = <0x308b0000 0x10000>;
>  				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>,
	Daniel Baluta <daniel.baluta@nxp.com>
Cc: devicetree@vger.kernel.org, patchwork-lst@pengutronix.de,
	NXP Linux Team <linux-imx@nxp.com>,
	kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq: fix SAI compatible
Date: Tue, 23 Jul 2019 15:33:43 +0800	[thread overview]
Message-ID: <20190723073342.GG15632@dragon> (raw)
In-Reply-To: <20190717095436.28154-1-l.stach@pengutronix.de>

Add Daniel for comment.

On Wed, Jul 17, 2019 at 11:54:36AM +0200, Lucas Stach wrote:
> The i.MX8M SAI block is not compatible with the i.MX6SX one, as the
> register layout has changed due to two version registers being added
> at the beginning of the address map. Remove the bogus compatible.
> 
> Fixes: 8c61538dc945 "arm64: dts: imx8mq: Add SAI2 node"

The format should be the following.  I can fix it when applying though.

Fixes: 8c61538dc945 ("arm64: dts: imx8mq: Add SAI2 node")

Shawn

> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 9326bd4150a3..0c533c66b340 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -718,8 +718,7 @@
>  
>  			sai2: sai@308b0000 {
>  				#sound-dai-cells = <0>;
> -				compatible = "fsl,imx8mq-sai",
> -					     "fsl,imx6sx-sai";
> +				compatible = "fsl,imx8mq-sai";
>  				reg = <0x308b0000 0x10000>;
>  				interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clk IMX8MQ_CLK_SAI2_IPG>,
> -- 
> 2.20.1
> 

  reply	other threads:[~2019-07-23  7:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  9:54 [PATCH] arm64: dts: imx8mq: fix SAI compatible Lucas Stach
2019-07-17  9:54 ` Lucas Stach
2019-07-23  7:33 ` Shawn Guo [this message]
2019-07-23  7:33   ` Shawn Guo
2019-07-23  7:37   ` Daniel Baluta
2019-07-23  7:37     ` Daniel Baluta
2019-07-23  7:38 ` Shawn Guo
2019-07-23  7:38   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190723073342.GG15632@dragon \
    --to=shawnguo@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=patchwork-lst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.