From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mst@redhat.com, jasowang@redhat.com,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, eric.auger.pro@gmail.com,
hch@lst.de
Subject: Re: [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call
Date: Tue, 23 Jul 2019 17:38:51 +0200 [thread overview]
Message-ID: <20190723153851.GE720@lst.de> (raw)
In-Reply-To: <e4a288f2-a93a-5ce4-32da-f5434302551f@arm.com>
On Mon, Jul 22, 2019 at 04:36:09PM +0100, Robin Murphy wrote:
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index c8be1c4f5b55..37c143971211 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -262,7 +262,7 @@ size_t virtio_max_dma_size(struct virtio_device *vdev)
>> {
>> size_t max_segment_size = SIZE_MAX;
>> - if (vring_use_dma_api(vdev))
>> + if (vring_use_dma_api(vdev) && vdev->dev.dma_mask)
>
> Hmm, might it make sense to roll that check up into vring_use_dma_api()
> itself? After all, if the device has no mask then it's likely that other
> DMA API ops wouldn't really work as expected either.
Makes sense to me.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: mst@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Eric Auger <eric.auger@redhat.com>,
iommu@lists.linux-foundation.org, eric.auger.pro@gmail.com,
hch@lst.de, m.szyprowski@samsung.com
Subject: Re: [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call
Date: Tue, 23 Jul 2019 17:38:51 +0200 [thread overview]
Message-ID: <20190723153851.GE720@lst.de> (raw)
In-Reply-To: <e4a288f2-a93a-5ce4-32da-f5434302551f@arm.com>
On Mon, Jul 22, 2019 at 04:36:09PM +0100, Robin Murphy wrote:
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index c8be1c4f5b55..37c143971211 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -262,7 +262,7 @@ size_t virtio_max_dma_size(struct virtio_device *vdev)
>> {
>> size_t max_segment_size = SIZE_MAX;
>> - if (vring_use_dma_api(vdev))
>> + if (vring_use_dma_api(vdev) && vdev->dev.dma_mask)
>
> Hmm, might it make sense to roll that check up into vring_use_dma_api()
> itself? After all, if the device has no mask then it's likely that other
> DMA API ops wouldn't really work as expected either.
Makes sense to me.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: Eric Auger <eric.auger@redhat.com>,
eric.auger.pro@gmail.com, hch@lst.de, m.szyprowski@samsung.com,
mst@redhat.com, jasowang@redhat.com,
virtualization@lists.linux-foundation.org,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call
Date: Tue, 23 Jul 2019 17:38:51 +0200 [thread overview]
Message-ID: <20190723153851.GE720@lst.de> (raw)
In-Reply-To: <e4a288f2-a93a-5ce4-32da-f5434302551f@arm.com>
On Mon, Jul 22, 2019 at 04:36:09PM +0100, Robin Murphy wrote:
>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
>> index c8be1c4f5b55..37c143971211 100644
>> --- a/drivers/virtio/virtio_ring.c
>> +++ b/drivers/virtio/virtio_ring.c
>> @@ -262,7 +262,7 @@ size_t virtio_max_dma_size(struct virtio_device *vdev)
>> {
>> size_t max_segment_size = SIZE_MAX;
>> - if (vring_use_dma_api(vdev))
>> + if (vring_use_dma_api(vdev) && vdev->dev.dma_mask)
>
> Hmm, might it make sense to roll that check up into vring_use_dma_api()
> itself? After all, if the device has no mask then it's likely that other
> DMA API ops wouldn't really work as expected either.
Makes sense to me.
next prev parent reply other threads:[~2019-07-23 15:39 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 14:55 [PATCH 0/2] Fix NULL pointer dereference with virtio-blk-pci and virtual IOMMU Eric Auger
2019-07-22 14:55 ` Eric Auger
2019-07-22 14:55 ` [PATCH 1/2] dma-mapping: Protect dma_addressing_limited against NULL dma_mask Eric Auger
2019-07-22 14:55 ` Eric Auger
2019-07-22 15:26 ` Christoph Hellwig
2019-07-22 15:26 ` Christoph Hellwig
2019-07-22 15:26 ` Christoph Hellwig
2019-07-22 15:46 ` Auger Eric
2019-07-22 15:46 ` Auger Eric
2019-07-22 15:46 ` Auger Eric
2019-07-22 14:55 ` Eric Auger
2019-07-22 14:55 ` [PATCH 2/2] virtio/virtio_ring: Fix the dma_max_mapping_size call Eric Auger
2019-07-22 14:55 ` Eric Auger
2019-07-22 15:27 ` Christoph Hellwig
2019-07-22 15:27 ` Christoph Hellwig
2019-07-22 15:27 ` Christoph Hellwig
2019-07-22 15:39 ` Michael S. Tsirkin
2019-07-22 15:39 ` Michael S. Tsirkin
2019-07-22 15:39 ` Michael S. Tsirkin
2019-07-22 15:33 ` Michael S. Tsirkin
2019-07-22 15:33 ` Michael S. Tsirkin
2019-07-22 15:33 ` Michael S. Tsirkin
2019-07-23 15:38 ` Christoph Hellwig
2019-07-23 15:38 ` Christoph Hellwig
2019-07-23 15:47 ` Michael S. Tsirkin
2019-07-23 15:47 ` Michael S. Tsirkin
2019-07-23 15:47 ` Michael S. Tsirkin
2019-07-23 15:38 ` Christoph Hellwig
2019-07-22 15:36 ` Robin Murphy
2019-07-22 15:36 ` Robin Murphy
2019-07-22 15:45 ` Michael S. Tsirkin
2019-07-22 15:45 ` Michael S. Tsirkin
2019-07-22 15:45 ` Michael S. Tsirkin
2019-07-23 15:38 ` Christoph Hellwig [this message]
2019-07-23 15:38 ` Christoph Hellwig
2019-07-23 15:38 ` Christoph Hellwig
2019-07-24 22:10 ` Michael S. Tsirkin
2019-07-24 22:10 ` Michael S. Tsirkin
2019-07-24 22:10 ` Michael S. Tsirkin
2019-07-25 5:25 ` Christoph Hellwig
2019-07-25 5:25 ` Christoph Hellwig
2019-07-25 5:25 ` Christoph Hellwig
2019-07-25 11:53 ` Auger Eric
2019-07-25 11:53 ` Auger Eric
2019-07-25 13:04 ` Christoph Hellwig
2019-07-25 13:04 ` Christoph Hellwig
2019-07-25 16:32 ` Auger Eric
2019-07-25 16:32 ` Auger Eric
2019-07-25 16:32 ` Auger Eric
2019-07-25 13:04 ` Christoph Hellwig
2019-07-25 11:53 ` Auger Eric
2019-07-22 15:36 ` Robin Murphy
2019-07-22 14:55 ` Eric Auger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723153851.GE720@lst.de \
--to=hch@lst.de \
--cc=eric.auger.pro@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=robin.murphy@arm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.