From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
mbrugger@suse.com, bcm-kernel-feedback-list@broadcom.com,
Stefan Wahren <wahrenst@gmx.net>,
hch@lst.de, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect
Date: Tue, 23 Jul 2019 18:34:33 +0200 [thread overview]
Message-ID: <20190723163433.GA2234@lst.de> (raw)
In-Reply-To: <20190723161934.4590-1-nsaenzjulienne@suse.de>
> +static int bcm2835_needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size)
Too long line..
> +void __init bcm2835_init_early(void)
> +{
> + if(of_machine_is_compatible("brcm,bcm2711"))
Odd formatting.
Otherwise this looks good to me.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Eric Anholt <eric@anholt.net>, Stefan Wahren <wahrenst@gmx.net>,
mbrugger@suse.com, hch@lst.de,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect
Date: Tue, 23 Jul 2019 18:34:33 +0200 [thread overview]
Message-ID: <20190723163433.GA2234@lst.de> (raw)
In-Reply-To: <20190723161934.4590-1-nsaenzjulienne@suse.de>
> +static int bcm2835_needs_bounce(struct device *dev, dma_addr_t dma_addr, size_t size)
Too long line..
> +void __init bcm2835_init_early(void)
> +{
> + if(of_machine_is_compatible("brcm,bcm2711"))
Odd formatting.
Otherwise this looks good to me.
next prev parent reply other threads:[~2019-07-23 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 16:19 [RFC] ARM: bcm2835: register dmabounce on devices hooked to main interconnect Nicolas Saenz Julienne
2019-07-23 16:19 ` Nicolas Saenz Julienne
2019-07-23 16:34 ` Christoph Hellwig [this message]
2019-07-23 16:34 ` Christoph Hellwig
2019-07-27 8:36 ` Florian Fainelli
2019-07-27 8:36 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723163433.GA2234@lst.de \
--to=hch@lst.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mbrugger@suse.com \
--cc=nsaenzjulienne@suse.de \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.