From: Pavel Machek <pavel@ucw.cz>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: fix typos
Date: Wed, 24 Jul 2019 13:47:02 +0200 [thread overview]
Message-ID: <20190724114702.GB26116@amd> (raw)
In-Reply-To: <7ae7157b-1336-f4a6-59a3-b1ac6307bd8d@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1327 bytes --]
On Wed 2019-07-24 11:36:23, Suzuki K Poulose wrote:
>
>
> On 24/07/2019 11:03, Pavel Machek wrote:
> >
> >Fix typos in comments.
> >
> >Signed-off-by: Pavel Machek <pavel@denx.de>
> >
> >diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> >index 55db77f641..1d66191 100644
> >--- a/drivers/hwtracing/coresight/coresight.c
> >+++ b/drivers/hwtracing/coresight/coresight.c
> >@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
> > if (!i_csdev->orphan)
> > return 0;
> > /*
> >- * Circle throuch all the connection of that component. If we find
> >+ * Circle through all the connections of that component. If we find
> > * an orphan connection whose name matches @csdev, link it.
>
> We have stopped using name to match the csdev and switched to fwnode
> handles. Please could you update the comment to reflect this, while you are
> at it ?
> Otherwise looks fine to me.
I guess best way would be to apply this and then fix up the facts in a
comment... or feel free to just fix it up. I am not best person to fix
facts there...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: mathieu.poirier@linaro.org, alexander.shishkin@linux.intel.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: fix typos
Date: Wed, 24 Jul 2019 13:47:02 +0200 [thread overview]
Message-ID: <20190724114702.GB26116@amd> (raw)
In-Reply-To: <7ae7157b-1336-f4a6-59a3-b1ac6307bd8d@arm.com>
[-- Attachment #1: Type: text/plain, Size: 1327 bytes --]
On Wed 2019-07-24 11:36:23, Suzuki K Poulose wrote:
>
>
> On 24/07/2019 11:03, Pavel Machek wrote:
> >
> >Fix typos in comments.
> >
> >Signed-off-by: Pavel Machek <pavel@denx.de>
> >
> >diff --git a/drivers/hwtracing/coresight/coresight.c b/drivers/hwtracing/coresight/coresight.c
> >index 55db77f641..1d66191 100644
> >--- a/drivers/hwtracing/coresight/coresight.c
> >+++ b/drivers/hwtracing/coresight/coresight.c
> >@@ -1001,7 +1001,7 @@ static int coresight_orphan_match(struct device *dev, void *data)
> > if (!i_csdev->orphan)
> > return 0;
> > /*
> >- * Circle throuch all the connection of that component. If we find
> >+ * Circle through all the connections of that component. If we find
> > * an orphan connection whose name matches @csdev, link it.
>
> We have stopped using name to match the csdev and switched to fwnode
> handles. Please could you update the comment to reflect this, while you are
> at it ?
> Otherwise looks fine to me.
I guess best way would be to apply this and then fix up the facts in a
comment... or feel free to just fix it up. I am not best person to fix
facts there...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2019-07-24 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 10:03 [PATCH] coresight: fix typos Pavel Machek
2019-07-24 10:03 ` Pavel Machek
2019-07-24 10:36 ` Suzuki K Poulose
2019-07-24 10:36 ` Suzuki K Poulose
2019-07-24 11:47 ` Pavel Machek [this message]
2019-07-24 11:47 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724114702.GB26116@amd \
--to=pavel@ucw.cz \
--cc=alexander.shishkin@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.