Re: [PATCH] arm: dts: exynos: Add GPU/Mali T604 node to exynos5250

[Krzysztof Kozlowski <krzk@kernel.org>]

Hi,

Thanks for the patch.

On Wed, Jul 24, 2019 at 09:20:08AM +0200, Guillaume GARDET wrote:
> From: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Add nodes for GPU (Mali T604) to Exynos5250, disabled by default.

Why disabled? If tested I would expect it to be enabled at least on
tested platforms.

> Tested with kmscube on Chromebook snow.
> 
> Signed-off-by: Guillaume GARDET <guillaume.gardet@arm.com>
> 
> Cc: Kukjin Kim <kgene@kernel.org>
> Cc: Krzysztof Kozlowski <krzk@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> 
> ---
>  arch/arm/boot/dts/exynos5250.dtsi | 47 +++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index d5e0392b409e..5ce4b2853cf2 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -1097,6 +1097,53 @@
>  		 */
>  		clock-frequency = <24000000>;
>  	};
> +
> +	mali: gpu@0x11800000 {

1. Put the node under /soc (as recently pointed out by Marek Szyprowski)
in an address-sorted mode... if possible (nodes are mixed so find some
reasonable place based on address_.
2. Fix errors from:
make dtbs W=1

> +		compatible = "samsung,exynos5250-mali", "arm,mali-t604";

You also need to update the bindings.

> +		reg = <0x11800000 0x5000>;
> +		interrupts = <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>,
> +		             <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>,

Please run checkpatch and fix the errors.

> +			     <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "job", "mmu", "gpu";
> +		clocks = <&clock CLK_G3D>;
> +		clock-names = "g3d";
> +		operating-points-v2 = <&gpu_opp_table>;
> +		power-domains = <&pd_g3d>;
> +		status = "disabled";
> +	};
> +
> +	gpu_opp_table: gpu-opp-table {

GPU opp table as subnode of Mali node.

Best regards,
Krzysztof