All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	linux-renesas-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Magnus Damm <magnus.damm@gmail.com>, Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH/RFC repost] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps
Date: Thu, 25 Jul 2019 09:35:30 +0200	[thread overview]
Message-ID: <20190725073530.GA1323@kunai> (raw)
In-Reply-To: <20190725055721.37mcdtpeer3knrxa@verge.net.au>

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]


> Sure, how about something like this:
> 
>                 /* TX clock internal delay mode is required for reliable
>                  * 1Gbps communication using the KSZ9031RNX phy present on
>                  * the Ebisu board, however, TX clock internal delay mode
>                  * isn't supported on r8a77990.  Thus, limit speed to
>                  * 100Mbps for reliable communication.
>                  */
> 		max-speed = <100>;

Yes, I like it. If DTs have kernel coding style, there should be a blank
'/*' at the beginning.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Simon Horman <horms@verge.net.au>
Cc: linux-renesas-soc@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH/RFC repost] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps
Date: Thu, 25 Jul 2019 09:35:30 +0200	[thread overview]
Message-ID: <20190725073530.GA1323@kunai> (raw)
In-Reply-To: <20190725055721.37mcdtpeer3knrxa@verge.net.au>


[-- Attachment #1.1: Type: text/plain, Size: 557 bytes --]


> Sure, how about something like this:
> 
>                 /* TX clock internal delay mode is required for reliable
>                  * 1Gbps communication using the KSZ9031RNX phy present on
>                  * the Ebisu board, however, TX clock internal delay mode
>                  * isn't supported on r8a77990.  Thus, limit speed to
>                  * 100Mbps for reliable communication.
>                  */
> 		max-speed = <100>;

Yes, I like it. If DTs have kernel coding style, there should be a blank
'/*' at the beginning.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-25  7:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17 12:57 [PATCH/RFC repost] arm64: dts: renesas: ebisu, draak: Limit EtherAVB to 100Mbps Simon Horman
2019-07-17 12:57 ` Simon Horman
2019-07-17 13:24 ` Kieran Bingham
2019-07-17 13:24   ` Kieran Bingham
2019-07-24 10:52   ` Simon Horman
2019-07-24 10:52     ` Simon Horman
2019-07-17 13:26 ` Wolfram Sang
2019-07-17 13:26   ` Wolfram Sang
2019-07-24 10:52   ` Simon Horman
2019-07-24 10:52     ` Simon Horman
2019-07-24 21:04     ` Wolfram Sang
2019-07-24 21:04       ` Wolfram Sang
2019-07-25  5:57       ` Simon Horman
2019-07-25  5:57         ` Simon Horman
2019-07-25  7:35         ` Wolfram Sang [this message]
2019-07-25  7:35           ` Wolfram Sang
2019-07-25  9:51           ` Simon Horman
2019-07-25  9:51             ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190725073530.GA1323@kunai \
    --to=wsa@the-dreams.de \
    --cc=andrew@lunn.ch \
    --cc=geert+renesas@glider.be \
    --cc=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.