All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	tglx@linutronix.de, alexios.zavras@intel.com,
	gregkh@linuxfoundation.org, kstewart@linuxfoundation.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant
Date: Sat, 27 Jul 2019 20:00:56 +0000	[thread overview]
Message-ID: <20190727210056.63e7e9d2@archlinux> (raw)
In-Reply-To: <20190721213533.9214-1-christophe.jaillet@wanadoo.fr>

On Sun, 21 Jul 2019 23:35:33 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Everything is about mmc35240_ except MMC53240_WAIT_SET_RESET (3 and 5
> switched).
> 
> This is likely a typo. Define and use MMC35240_WAIT_SET_RESET instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see what we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/magnetometer/mmc35240.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 7de10281ad9e..425cdd07b4e5 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -53,7 +53,7 @@
>  #define MMC35240_CTRL1_BW_SHIFT		0
>  
>  #define MMC35240_WAIT_CHARGE_PUMP	50000	/* us */
> -#define MMC53240_WAIT_SET_RESET		1000	/* us */
> +#define MMC35240_WAIT_SET_RESET		1000	/* us */
>  
>  /*
>   * Memsic OTP process code piece is put here for reference:
> @@ -225,7 +225,7 @@ static int mmc35240_init(struct mmc35240_data *data)
>  	ret = mmc35240_hw_set(data, true);
>  	if (ret < 0)
>  		return ret;
> -	usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
> +	usleep_range(MMC35240_WAIT_SET_RESET, MMC35240_WAIT_SET_RESET + 1);
>  
>  	ret = mmc35240_hw_set(data, false);
>  	if (ret < 0)

WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
	tglx@linutronix.de, alexios.zavras@intel.com,
	gregkh@linuxfoundation.org, kstewart@linuxfoundation.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant
Date: Sat, 27 Jul 2019 21:00:56 +0100	[thread overview]
Message-ID: <20190727210056.63e7e9d2@archlinux> (raw)
In-Reply-To: <20190721213533.9214-1-christophe.jaillet@wanadoo.fr>

On Sun, 21 Jul 2019 23:35:33 +0200
Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:

> Everything is about mmc35240_ except MMC53240_WAIT_SET_RESET (3 and 5
> switched).
> 
> This is likely a typo. Define and use MMC35240_WAIT_SET_RESET instead.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to see what we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/magnetometer/mmc35240.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 7de10281ad9e..425cdd07b4e5 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -53,7 +53,7 @@
>  #define MMC35240_CTRL1_BW_SHIFT		0
>  
>  #define MMC35240_WAIT_CHARGE_PUMP	50000	/* us */
> -#define MMC53240_WAIT_SET_RESET		1000	/* us */
> +#define MMC35240_WAIT_SET_RESET		1000	/* us */
>  
>  /*
>   * Memsic OTP process code piece is put here for reference:
> @@ -225,7 +225,7 @@ static int mmc35240_init(struct mmc35240_data *data)
>  	ret = mmc35240_hw_set(data, true);
>  	if (ret < 0)
>  		return ret;
> -	usleep_range(MMC53240_WAIT_SET_RESET, MMC53240_WAIT_SET_RESET + 1);
> +	usleep_range(MMC35240_WAIT_SET_RESET, MMC35240_WAIT_SET_RESET + 1);
>  
>  	ret = mmc35240_hw_set(data, false);
>  	if (ret < 0)


  reply	other threads:[~2019-07-27 20:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-21 21:35 [PATCH] iio: magnetometer: mmc35240: Fix a typo in the name of a constant Christophe JAILLET
2019-07-21 21:35 ` Christophe JAILLET
2019-07-27 20:00 ` Jonathan Cameron [this message]
2019-07-27 20:00   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190727210056.63e7e9d2@archlinux \
    --to=jic23@kernel.org \
    --cc=alexios.zavras@intel.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=kstewart@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.