From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Maximilian Luz <luzmaximilian@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input <linux-input@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Chen Yu <yu.c.chen@intel.com>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check
Date: Sun, 28 Jul 2019 12:57:26 +0300 [thread overview]
Message-ID: <20190728095726.GA775@penguin> (raw)
In-Reply-To: <CAHp75VdsL+-bhAUcxLKFKLZedN3gFD3jxnhELD1RtKGSHdagjw@mail.gmail.com>
On Sat, Jul 27, 2019 at 03:26:41PM +0300, Andy Shevchenko wrote:
> On Sat, Jul 27, 2019 at 12:15 PM Dmitry Torokhov
> <dmitry.torokhov@gmail.com> wrote:
> >
> > On Thu, Jul 25, 2019 at 08:57:53PM +0300, Andy Shevchenko wrote:
> > > On Sat, Jul 20, 2019 at 6:05 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
> > > >
> > > > Do not use the surfacepro3_button driver on newer Microsoft Surface
> > > > models, only use it on the Surface Pro 3 and 4. Newer models (5th, 6th
> > > > and possibly future generations) use the same device as the Surface Pro
> > > > 4 to represent their volume and power buttons (MSHW0040), but their
> > > > actual implementation is significantly different. This patch ensures
> > > > that the surfacepro3_button driver is only used on the Pro 3 and 4
> > > > models, allowing a different driver to bind on other models.
> > > >
> > >
> > > Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> > >
> > > assuming it will go thru Input subsystem.
> >
> > I can take it, but I do not think it is dependent on the other change
> > and thus can go through platform tree as well.
>
> Pkease, take it. I do not expect any changes to the driver this cycle.
OK, applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2019-07-28 9:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 15:05 [PATCH v3 0/2] Support for buttons on newer MS Surface devices Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-20 15:05 ` [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-25 17:57 ` Andy Shevchenko
2019-07-27 9:15 ` Dmitry Torokhov
2019-07-27 12:26 ` Andy Shevchenko
2019-07-28 9:57 ` Dmitry Torokhov [this message]
2019-07-26 1:48 ` Yu Chen
2019-07-20 15:05 ` [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-22 8:00 ` Enrico Weigelt, metux IT consult
2019-07-23 11:29 ` Maximilian Luz
2019-07-27 9:14 ` Dmitry Torokhov
2019-07-27 12:01 ` Maximilian Luz
2019-07-28 10:01 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728095726.GA775@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.