From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Chen Yu <yu.c.chen@intel.com>, Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: Re: [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices
Date: Sun, 28 Jul 2019 13:01:38 +0300 [thread overview]
Message-ID: <20190728100138.GC775@penguin> (raw)
In-Reply-To: <fb53b082-4d83-83a6-1ae6-b9fae9dc750f@gmail.com>
On Sat, Jul 27, 2019 at 02:01:26PM +0200, Maximilian Luz wrote:
> On 7/27/19 11:14 AM, Dmitry Torokhov wrote:
> > On Sat, Jul 20, 2019 at 05:05:11PM +0200, Maximilian Luz wrote:
> > > -
> > > - error = gpiod_count(dev, NULL);
> > > - if (error < 0) {
> > > - dev_dbg(dev, "no GPIO attached, ignoring...\n");
> > > - return -ENODEV;
> >
> > I do not think we need to move this into individual "check" functions.
> > It is needed in all cases so we should keep it here.
> >
> > How about version below?
>
> Makes sense, looks good to me!
OK, great, applied.
--
Dmitry
prev parent reply other threads:[~2019-07-28 10:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-20 15:05 [PATCH v3 0/2] Support for buttons on newer MS Surface devices Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-20 15:05 ` [PATCH v3 1/2] platform/x86: surfacepro3_button: Fix device check Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-25 17:57 ` Andy Shevchenko
2019-07-27 9:15 ` Dmitry Torokhov
2019-07-27 12:26 ` Andy Shevchenko
2019-07-28 9:57 ` Dmitry Torokhov
2019-07-26 1:48 ` Yu Chen
2019-07-20 15:05 ` [PATCH v3 2/2] Input: soc_button_array - Add support for newer surface devices Maximilian Luz
2019-07-20 15:05 ` Maximilian Luz
2019-07-22 8:00 ` Enrico Weigelt, metux IT consult
2019-07-23 11:29 ` Maximilian Luz
2019-07-27 9:14 ` Dmitry Torokhov
2019-07-27 12:01 ` Maximilian Luz
2019-07-28 10:01 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190728100138.GC775@penguin \
--to=dmitry.torokhov@gmail.com \
--cc=andy@infradead.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.