From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Rik van Riel <riel@redhat.com>, Mel Gorman <mgorman@suse.de>,
jhladky@redhat.com, lvenanci@redhat.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RESEND] autonuma: Fix scan period updating
Date: Mon, 29 Jul 2019 12:58:45 +0530 [thread overview]
Message-ID: <20190729072845.GC7168@linux.vnet.ibm.com> (raw)
In-Reply-To: <87ef295yn9.fsf@yhuang-dev.intel.com>
> >>
> >> if (lr_ratio >= NUMA_PERIOD_THRESHOLD)
> >> slow down scanning
> >> else if (sp_ratio >= NUMA_PERIOD_THRESHOLD) {
> >> if (NUMA_PERIOD_SLOTS - lr_ratio >= NUMA_PERIOD_THRESHOLD)
> >> speed up scanning
>
> Thought about this again. For example, a multi-threads workload runs on
> a 4-sockets machine, and most memory accesses are shared. The optimal
> situation will be pseudo-interleaving, that is, spreading memory
> accesses evenly among 4 NUMA nodes. Where "share" >> "private", and
> "remote" > "local". And we should slow down scanning to reduce the
> overhead.
>
> What do you think about this?
If all 4 nodes have equal access, then all 4 nodes will be active nodes.
From task_numa_fault()
if (!priv && !local && ng && ng->active_nodes > 1 &&
numa_is_active_node(cpu_node, ng) &&
numa_is_active_node(mem_node, ng))
local = 1;
Hence all accesses will be accounted as local. Hence scanning would slow
down.
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2019-07-29 7:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 8:01 [PATCH RESEND] autonuma: Fix scan period updating Huang, Ying
2019-07-25 17:35 ` Srikar Dronamraju
2019-07-26 7:45 ` Huang, Ying
2019-07-26 9:20 ` Srikar Dronamraju
2019-07-29 3:04 ` Huang, Ying
2019-07-29 7:28 ` Srikar Dronamraju [this message]
2019-07-29 8:16 ` Huang, Ying
2019-07-29 8:56 ` Mel Gorman
2019-07-30 1:38 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190729072845.GC7168@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=jhladky@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lvenanci@redhat.com \
--cc=mgorman@suse.de \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=riel@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.