From: Ido Schimmel <idosch@idosch.org>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, roopa@cumulusnetworks.com,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
davem@davemloft.net,
Horatiu Vultur <horatiu.vultur@microchip.com>
Subject: Re: [Bridge] [PATCH] net: bridge: Allow bridge to joing multicast groups
Date: Tue, 30 Jul 2019 13:04:16 +0300 [thread overview]
Message-ID: <20190730100416.GA13250@splinter> (raw)
In-Reply-To: <20190730083027.biuzy7h5dbq7pik3@lx-anielsen.microsemi.net>
On Tue, Jul 30, 2019 at 10:30:28AM +0200, Allan W. Nielsen wrote:
> The 07/30/2019 10:06, Ido Schimmel wrote:
> > As a bonus, existing drivers could benefit from it, as MDB entries are already
> > notified by MAC.
> Not sure I follow. When FDB entries are added, it also generates notification
> events.
I meant the switchdev notification sent to drivers:
/* SWITCHDEV_OBJ_ID_PORT_MDB */
struct switchdev_obj_port_mdb {
struct switchdev_obj obj;
unsigned char addr[ETH_ALEN];
u16 vid;
};
By extending MDB entries to also be keyed by MAC you basically get a lot
of things for free without duplicating the same code for multicast FDBs.
AFAICS, then only change in the fast path is in br_mdb_get() where you
need to use DMAC as key in case Ethertype is not IPv4/IPv6.
WARNING: multiple messages have this Message-ID (diff)
From: Ido Schimmel <idosch@idosch.org>
To: "Allan W. Nielsen" <allan.nielsen@microchip.com>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
roopa@cumulusnetworks.com, davem@davemloft.net,
bridge@lists.linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: bridge: Allow bridge to joing multicast groups
Date: Tue, 30 Jul 2019 13:04:16 +0300 [thread overview]
Message-ID: <20190730100416.GA13250@splinter> (raw)
In-Reply-To: <20190730083027.biuzy7h5dbq7pik3@lx-anielsen.microsemi.net>
On Tue, Jul 30, 2019 at 10:30:28AM +0200, Allan W. Nielsen wrote:
> The 07/30/2019 10:06, Ido Schimmel wrote:
> > As a bonus, existing drivers could benefit from it, as MDB entries are already
> > notified by MAC.
> Not sure I follow. When FDB entries are added, it also generates notification
> events.
I meant the switchdev notification sent to drivers:
/* SWITCHDEV_OBJ_ID_PORT_MDB */
struct switchdev_obj_port_mdb {
struct switchdev_obj obj;
unsigned char addr[ETH_ALEN];
u16 vid;
};
By extending MDB entries to also be keyed by MAC you basically get a lot
of things for free without duplicating the same code for multicast FDBs.
AFAICS, then only change in the fast path is in br_mdb_get() where you
need to use DMAC as key in case Ethertype is not IPv4/IPv6.
next prev parent reply other threads:[~2019-07-30 10:04 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 11:44 [Bridge] [PATCH] net: bridge: Allow bridge to joing multicast groups Horatiu Vultur
2019-07-25 11:44 ` Horatiu Vultur
2019-07-25 13:06 ` [Bridge] " Nikolay Aleksandrov
2019-07-25 13:06 ` Nikolay Aleksandrov
2019-07-25 13:21 ` [Bridge] " Nikolay Aleksandrov
2019-07-25 13:21 ` Nikolay Aleksandrov
2019-07-25 14:21 ` [Bridge] " Horatiu Vultur
2019-07-25 14:21 ` Horatiu Vultur
2019-07-26 8:41 ` [Bridge] " Nikolay Aleksandrov
2019-07-26 8:41 ` Nikolay Aleksandrov
2019-07-26 9:26 ` [Bridge] " Nikolay Aleksandrov
2019-07-26 9:26 ` Nikolay Aleksandrov
2019-07-26 12:02 ` [Bridge] " Horatiu Vultur
2019-07-26 12:02 ` Horatiu Vultur
2019-07-26 12:31 ` [Bridge] " Nikolay Aleksandrov
2019-07-26 12:31 ` Nikolay Aleksandrov
2019-07-29 12:14 ` [Bridge] " Allan W. Nielsen
2019-07-29 12:14 ` Allan W. Nielsen
2019-07-29 12:22 ` [Bridge] " Nikolay Aleksandrov
2019-07-29 12:22 ` Nikolay Aleksandrov
2019-07-29 12:50 ` [Bridge] " Nikolay Aleksandrov
2019-07-29 12:50 ` Nikolay Aleksandrov
2019-07-29 13:14 ` [Bridge] " Allan W. Nielsen
2019-07-29 13:14 ` Allan W. Nielsen
2019-07-29 13:42 ` [Bridge] " Nikolay Aleksandrov
2019-07-29 13:42 ` Nikolay Aleksandrov
2019-07-29 13:52 ` [Bridge] " Allan W. Nielsen
2019-07-29 13:52 ` Allan W. Nielsen
2019-07-29 14:21 ` [Bridge] " Nikolay Aleksandrov
2019-07-29 14:21 ` Nikolay Aleksandrov
2019-07-29 14:35 ` [Bridge] " Allan W. Nielsen
2019-07-29 14:35 ` Allan W. Nielsen
2019-07-29 17:51 ` [Bridge] " Ido Schimmel
2019-07-29 17:51 ` Ido Schimmel
2019-07-30 6:27 ` [Bridge] " Allan W. Nielsen
2019-07-30 6:27 ` Allan W. Nielsen
2019-07-30 7:06 ` [Bridge] " Ido Schimmel
2019-07-30 7:06 ` Ido Schimmel
2019-07-30 8:30 ` [Bridge] " Allan W. Nielsen
2019-07-30 8:30 ` Allan W. Nielsen
2019-07-30 8:58 ` [Bridge] " Nikolay Aleksandrov
2019-07-30 8:58 ` Nikolay Aleksandrov
2019-07-30 9:21 ` [Bridge] " Allan W. Nielsen
2019-07-30 9:21 ` Allan W. Nielsen
2019-07-30 9:55 ` [Bridge] " Nikolay Aleksandrov
2019-07-30 9:55 ` Nikolay Aleksandrov
2019-07-30 11:23 ` [Bridge] " Allan W. Nielsen
2019-07-30 11:23 ` Allan W. Nielsen
2019-07-30 10:04 ` Ido Schimmel [this message]
2019-07-30 10:04 ` Ido Schimmel
2019-07-30 12:19 ` [Bridge] " Allan W. Nielsen
2019-07-30 12:19 ` Allan W. Nielsen
2019-07-30 14:34 ` [Bridge] " Andrew Lunn
2019-07-30 14:34 ` Andrew Lunn
2019-07-30 19:00 ` [Bridge] " Allan W. Nielsen
2019-07-30 19:00 ` Allan W. Nielsen
2019-07-31 3:31 ` [Bridge] " Andrew Lunn
2019-07-31 3:31 ` Andrew Lunn
2019-07-31 8:01 ` [Bridge] " Allan W. Nielsen
2019-07-31 8:01 ` Allan W. Nielsen
2019-07-31 13:45 ` [Bridge] " Andrew Lunn
2019-07-31 13:45 ` Andrew Lunn
2019-07-31 19:38 ` [Bridge] " Allan W. Nielsen
2019-07-31 19:38 ` Allan W. Nielsen
2019-08-01 14:22 ` [Bridge] " Allan W. Nielsen
2019-08-01 14:22 ` Allan W. Nielsen
2019-07-26 13:46 ` [Bridge] " Andrew Lunn
2019-07-26 13:46 ` Andrew Lunn
2019-07-26 19:50 ` [Bridge] " Allan W. Nielsen
2019-07-26 19:50 ` Allan W. Nielsen
2019-07-27 3:02 ` [Bridge] " Andrew Lunn
2019-07-27 3:02 ` Andrew Lunn
2019-07-28 19:15 ` [Bridge] " Allan W. Nielsen
2019-07-28 19:15 ` Allan W. Nielsen
2019-07-28 23:07 ` [Bridge] " Andrew Lunn
2019-07-28 23:07 ` Andrew Lunn
2019-07-29 6:09 ` [Bridge] " Ido Schimmel
2019-07-29 6:09 ` Ido Schimmel
2019-07-29 12:43 ` [Bridge] " Allan W. Nielsen
2019-07-29 12:43 ` Allan W. Nielsen
2019-08-01 19:17 ` [Bridge] " Vivien Didelot
2019-08-01 19:17 ` Vivien Didelot
2019-08-01 19:48 ` [Bridge] " Horatiu Vultur
2019-08-01 19:48 ` Horatiu Vultur
2019-08-01 20:08 ` [Bridge] " Vivien Didelot
2019-08-01 20:08 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730100416.GA13250@splinter \
--to=idosch@idosch.org \
--cc=allan.nielsen@microchip.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.