From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Anson Huang <anson.huang@nxp.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Guido Gunther <agx@sigxcpu.org>,
Mike Turquette <mturquette@baylibre.com>,
Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] clk: imx8mq: Mark AHB clock as critical
Date: Tue, 30 Jul 2019 14:40:07 -0700 [thread overview]
Message-ID: <20190730214008.22F8E206E0@mail.kernel.org> (raw)
In-Reply-To: <20190730183818.mvoo5q3s4xylrqao@fsr-ub1664-175>
Quoting Abel Vesa (2019-07-30 11:38:18)
> On 19-07-30 10:52:30, Stephen Boyd wrote:
> > Quoting Abel Vesa (2019-07-30 00:22:55)
> > > Initially, the TMU_ROOT clock was marked as critical, which automatically
> > > made the AHB clock to stay always on. Since the TMU_ROOT clock is not
> > > marked as critical anymore, following commit:
> > >
> > > 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")
> > >
> > > all the clocks that derive from ipg_root clock (and implicitly ahb clock)
> > > would also have to enable, along with their own gate, the AHB clock.
> > >
> > > But considering that AHB is actually a bus that has to be always on, we mark
> > > it as critical in the clock provider driver and then all the clocks that
> > > derive from it can be controlled through the dedicated per IP gate which
> > > follows after the ipg_root clock.
> > >
> > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > > Tested-by: Daniel Baluta <daniel.baluta@nxp.com>
> > > Fixes: 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")
> > > ---
> > >
> >
> > Should I just apply this to clk-fixes branch?
> >
>
> Nope. The commit 431bdd1df48e is just in -next for now.
> So this has to be taken by Shawn, I think.
Ah ok. I thought it was related to some other problem someone was seeing
in the rc series but you're right, it was just linux-next for them.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Abel Vesa <abel.vesa@nxp.com>
Cc: Anson Huang <anson.huang@nxp.com>,
Guido Gunther <agx@sigxcpu.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org, Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Mike Turquette <mturquette@baylibre.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] clk: imx8mq: Mark AHB clock as critical
Date: Tue, 30 Jul 2019 14:40:07 -0700 [thread overview]
Message-ID: <20190730214008.22F8E206E0@mail.kernel.org> (raw)
In-Reply-To: <20190730183818.mvoo5q3s4xylrqao@fsr-ub1664-175>
Quoting Abel Vesa (2019-07-30 11:38:18)
> On 19-07-30 10:52:30, Stephen Boyd wrote:
> > Quoting Abel Vesa (2019-07-30 00:22:55)
> > > Initially, the TMU_ROOT clock was marked as critical, which automatically
> > > made the AHB clock to stay always on. Since the TMU_ROOT clock is not
> > > marked as critical anymore, following commit:
> > >
> > > 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")
> > >
> > > all the clocks that derive from ipg_root clock (and implicitly ahb clock)
> > > would also have to enable, along with their own gate, the AHB clock.
> > >
> > > But considering that AHB is actually a bus that has to be always on, we mark
> > > it as critical in the clock provider driver and then all the clocks that
> > > derive from it can be controlled through the dedicated per IP gate which
> > > follows after the ipg_root clock.
> > >
> > > Signed-off-by: Abel Vesa <abel.vesa@nxp.com>
> > > Tested-by: Daniel Baluta <daniel.baluta@nxp.com>
> > > Fixes: 431bdd1df48e ("clk: imx8mq: Remove CLK_IS_CRITICAL flag for IMX8MQ_CLK_TMU_ROOT")
> > > ---
> > >
> >
> > Should I just apply this to clk-fixes branch?
> >
>
> Nope. The commit 431bdd1df48e is just in -next for now.
> So this has to be taken by Shawn, I think.
Ah ok. I thought it was related to some other problem someone was seeing
in the rc series but you're right, it was just linux-next for them.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-30 21:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 7:22 [PATCH v3] clk: imx8mq: Mark AHB clock as critical Abel Vesa
2019-07-30 7:22 ` Abel Vesa
2019-07-30 17:52 ` Stephen Boyd
2019-07-30 17:52 ` Stephen Boyd
2019-07-30 18:38 ` Abel Vesa
2019-07-30 18:38 ` Abel Vesa
2019-07-30 21:40 ` Stephen Boyd [this message]
2019-07-30 21:40 ` Stephen Boyd
2019-08-03 15:04 ` Shawn Guo
2019-08-03 15:04 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730214008.22F8E206E0@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=anson.huang@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.